diff options
author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2020-05-08 19:27:09 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-08 19:27:09 +0200 |
commit | f07a0d937fd575248f404f784d0e3d41a59b7419 (patch) | |
tree | 8564a6a9f1a0653e3c04974ba69d26540f87010f /cmd/podman/registry/config.go | |
parent | 13db0f2b61b17e6f959fff832b40270352cd54da (diff) | |
parent | 69f62a1a9c09818f888247fec96344cae6e4b6ff (diff) | |
download | podman-f07a0d937fd575248f404f784d0e3d41a59b7419.tar.gz podman-f07a0d937fd575248f404f784d0e3d41a59b7419.tar.bz2 podman-f07a0d937fd575248f404f784d0e3d41a59b7419.zip |
Merge pull request #6143 from rhatdan/remote
default to tunnel without ABISupport tag
Diffstat (limited to 'cmd/podman/registry/config.go')
-rw-r--r-- | cmd/podman/registry/config.go | 29 |
1 files changed, 19 insertions, 10 deletions
diff --git a/cmd/podman/registry/config.go b/cmd/podman/registry/config.go index fc6eb538e..49d5bca74 100644 --- a/cmd/podman/registry/config.go +++ b/cmd/podman/registry/config.go @@ -22,6 +22,7 @@ const ( var ( podmanOptions entities.PodmanConfig podmanSync sync.Once + abiSupport = false ) // PodmanConfig returns an entities.PodmanConfig built up from @@ -39,23 +40,31 @@ func newPodmanConfig() { var mode entities.EngineMode switch runtime.GOOS { - case "darwin": - fallthrough - case "windows": + case "darwin", "windows": mode = entities.TunnelMode case "linux": - mode = entities.ABIMode + // Some linux clients might only be compiled without ABI + // support (e.g., podman-remote). + if abiSupport { + mode = entities.ABIMode + } else { + mode = entities.TunnelMode + } default: fmt.Fprintf(os.Stderr, "%s is not a supported OS", runtime.GOOS) os.Exit(1) } - // cobra.Execute() may not be called yet, so we peek at os.Args. - for _, v := range os.Args { - // Prefix checking works because of how default EngineMode's - // have been defined. - if strings.HasPrefix(v, "--remote") { - mode = entities.TunnelMode + // Check if need to fallback to the tunnel mode if --remote is used. + if abiSupport && mode == entities.ABIMode { + // cobra.Execute() may not be called yet, so we peek at os.Args. + for _, v := range os.Args { + // Prefix checking works because of how default EngineMode's + // have been defined. + if strings.HasPrefix(v, "--remote") { + mode = entities.TunnelMode + break + } } } |