diff options
author | Ed Santiago <santiago@redhat.com> | 2020-10-19 12:30:31 -0600 |
---|---|---|
committer | Ed Santiago <santiago@redhat.com> | 2020-10-20 11:32:49 -0600 |
commit | f5b3dc976c315976788bfb8b75bd0b8a40509324 (patch) | |
tree | eabd9e81f3314e296fb6afdf507031476d91820b /cmd/podman/report/diff.go | |
parent | 36682115b0f3f5f7cfcc6bc4580e5a7435b9a4d8 (diff) | |
download | podman-f5b3dc976c315976788bfb8b75bd0b8a40509324.tar.gz podman-f5b3dc976c315976788bfb8b75bd0b8a40509324.tar.bz2 podman-f5b3dc976c315976788bfb8b75bd0b8a40509324.zip |
Tests: Fix common flakes, and improve apiv2 test log
- apiv2 - the 'ten /info requests' test is flaking often,
taking ~8 seconds (our limit is 7, up from 5 a few weeks
ago). Brent suggested that the first /info call might be
expensive, because it needs to access storage. So, let's
prime it by running one /info outside the timing loop.
And, because even that continues to fail, bump it up
to 10 seconds and file #8076 to track the slowdown.
- toolbox test - WaitForReady() has timed out, even on one
occasion causing a run failure because it failed 3 times.
Solution: bump up timeout from 2s to 5s. Not really great,
but CI systems are underpowered, and it's not unreasonable
that 2s might be too low.
- sdnotify test - add a 'podman wait' between stop & rm.
This may prevent a "cannot rm container as it is running"
race condition.
While working on this, Brent and I noticed a few ways that
test-apiv2 logging can be improved:
- test name: when request is POST, display the jsonified
parameters, not the original input ones. This should
make it much easier to reproduce failures.
- use curl's "--write-out" option to capture http code,
content type, and request time. We were getting the
first two via grep from logged headers; this is cleaner.
And there was no other way to get timing. We now include
the timing as X-Response-Time in the log file.
- abort on *any* curl error, not just 7 (cannot connect).
Any error at all from curl is bad news.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'cmd/podman/report/diff.go')
0 files changed, 0 insertions, 0 deletions