summaryrefslogtreecommitdiff
path: root/cmd/podman/shared/funcs.go
diff options
context:
space:
mode:
authorValentin Rothberg <vrothberg@suse.com>2018-11-16 16:05:07 +0100
committerValentin Rothberg <vrothberg@suse.com>2018-11-16 16:05:07 +0100
commit780b790415f94ea41ef70bd97828ecb92a4f06d1 (patch)
tree57c9884a23aedfc95ddb05fccc456d6b791b24e9 /cmd/podman/shared/funcs.go
parent43de95df34a88d2ded4b62ab0c1763a33acac07e (diff)
downloadpodman-780b790415f94ea41ef70bd97828ecb92a4f06d1.tar.gz
podman-780b790415f94ea41ef70bd97828ecb92a4f06d1.tar.bz2
podman-780b790415f94ea41ef70bd97828ecb92a4f06d1.zip
runlabel: use shlex for splitting commands
Use github.com/google/shlex for splitting commands instead of splitting at whitespaces. This way, we avoid accidentally splitting single string arguments into mutliple ones. Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
Diffstat (limited to 'cmd/podman/shared/funcs.go')
-rw-r--r--cmd/podman/shared/funcs.go8
1 files changed, 7 insertions, 1 deletions
diff --git a/cmd/podman/shared/funcs.go b/cmd/podman/shared/funcs.go
index a92e0d547..8520c0616 100644
--- a/cmd/podman/shared/funcs.go
+++ b/cmd/podman/shared/funcs.go
@@ -5,6 +5,8 @@ import (
"os"
"path/filepath"
"strings"
+
+ "github.com/google/shlex"
)
func substituteCommand(cmd string) (string, error) {
@@ -42,7 +44,11 @@ func GenerateCommand(command, imageName, name string) ([]string, error) {
if name == "" {
name = imageName
}
- cmd := strings.Split(command, " ")
+
+ cmd, err := shlex.Split(command)
+ if err != nil {
+ return nil, err
+ }
prog, err := substituteCommand(cmd[0])
if err != nil {