diff options
| author | baude <bbaude@redhat.com> | 2019-02-13 13:22:58 -0600 |
|---|---|---|
| committer | baude <bbaude@redhat.com> | 2019-02-13 13:51:23 -0600 |
| commit | dd74467fd8dcbdab35b4c7fc2dc183d12fb228f2 (patch) | |
| tree | 647d88b335a6da3e6fbdf481694223fd9b7c8026 /cmd/podman | |
| parent | 8a16f83b0a13ab9de1cc905a3ff1132c75739995 (diff) | |
| download | podman-dd74467fd8dcbdab35b4c7fc2dc183d12fb228f2.tar.gz podman-dd74467fd8dcbdab35b4c7fc2dc183d12fb228f2.tar.bz2 podman-dd74467fd8dcbdab35b4c7fc2dc183d12fb228f2.zip | |
show container ports of network namespace
in cases where a container is part of a network namespace, we should
show the network namespace's ports when dealing with ports. this
impacts ps, kube, and port.
fixes: #846
Signed-off-by: baude <bbaude@redhat.com>
Diffstat (limited to 'cmd/podman')
| -rw-r--r-- | cmd/podman/port.go | 7 | ||||
| -rw-r--r-- | cmd/podman/shared/container.go | 7 |
2 files changed, 12 insertions, 2 deletions
diff --git a/cmd/podman/port.go b/cmd/podman/port.go index 5a5b6127b..be84da065 100644 --- a/cmd/podman/port.go +++ b/cmd/podman/port.go @@ -125,8 +125,13 @@ func portCmd(c *cliconfig.PortValues) error { if c.All { fmt.Println(con.ID()) } + + portmappings, err := con.PortMappings() + if err != nil { + return err + } // Iterate mappings - for _, v := range con.Config().PortMappings { + for _, v := range portmappings { hostIP := v.HostIP // Set host IP to 0.0.0.0 if blank if hostIP == "" { diff --git a/cmd/podman/shared/container.go b/cmd/podman/shared/container.go index c74d8fdce..81811e0f2 100644 --- a/cmd/podman/shared/container.go +++ b/cmd/podman/shared/container.go @@ -213,11 +213,16 @@ func NewBatchContainer(ctr *libpod.Container, opts PsOptions) (PsContainerOutput } } + ports, err := ctr.PortMappings() + if err != nil { + logrus.Errorf("unable to lookup namespace container for %s", ctr.ID()) + } + pso.ID = cid pso.Image = imageName pso.Command = command pso.Created = created - pso.Ports = portsToString(ctr.PortMappings()) + pso.Ports = portsToString(ports) pso.Names = ctr.Name() pso.IsInfra = ctr.IsInfra() pso.Status = status |