diff options
| author | Daniel J Walsh <dwalsh@redhat.com> | 2021-03-18 06:33:25 -0400 |
|---|---|---|
| committer | Matthew Heon <mheon@redhat.com> | 2021-03-29 13:23:14 -0400 |
| commit | 88672b58cfb9aed09b461cfd040472fdc3f867d9 (patch) | |
| tree | 9b8ceb607bc6bb98da7db8f417c999ffbea5ce6c /cmd/podman | |
| parent | 23f3805df253a6144a7d6891628b6da533a8ecc0 (diff) | |
| download | podman-88672b58cfb9aed09b461cfd040472fdc3f867d9.tar.gz podman-88672b58cfb9aed09b461cfd040472fdc3f867d9.tar.bz2 podman-88672b58cfb9aed09b461cfd040472fdc3f867d9.zip | |
Check if stdin is a term in --interactive --tty mode
If you are attempting to run a container in interactive mode, and want
a --tty, then there must be a terminal in use.
Docker exits right away when a user specifies to use a --interactive and
--TTY but the stdin is not a tty.
Currently podman will pull the image and then fail much later.
Podman will continue to run but will print an warning message.
Discussion in : https://github.com/containers/podman/issues/8916
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Diffstat (limited to 'cmd/podman')
| -rw-r--r-- | cmd/podman/containers/run.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/cmd/podman/containers/run.go b/cmd/podman/containers/run.go index 83a5d7b8a..db7180ca9 100644 --- a/cmd/podman/containers/run.go +++ b/cmd/podman/containers/run.go @@ -17,6 +17,7 @@ import ( "github.com/pkg/errors" "github.com/sirupsen/logrus" "github.com/spf13/cobra" + "golang.org/x/crypto/ssh/terminal" ) var ( @@ -106,6 +107,11 @@ func run(cmd *cobra.Command, args []string) error { return err } + // TODO: Breaking change should be made fatal in next major Release + if cliVals.TTY && cliVals.Interactive && !terminal.IsTerminal(int(os.Stdin.Fd())) { + logrus.Warnf("The input device is not a TTY. The --tty and --interactive flags might not work properly") + } + if af := cliVals.Authfile; len(af) > 0 { if _, err := os.Stat(af); err != nil { return err |