summaryrefslogtreecommitdiff
path: root/cmd/podman
diff options
context:
space:
mode:
authorPaul Holzinger <pholzing@redhat.com>2022-03-21 12:33:52 +0100
committerPaul Holzinger <pholzing@redhat.com>2022-03-21 13:19:31 +0100
commite3cc0717b219c76a417f88a7b905008ff851fab1 (patch)
treec4d8f6dfdc4c1a9d702acf1a1b7851312e91c4e6 /cmd/podman
parent248dbf6089922903d12553497a2faae27d1b503b (diff)
downloadpodman-e3cc0717b219c76a417f88a7b905008ff851fab1.tar.gz
podman-e3cc0717b219c76a417f88a7b905008ff851fab1.tar.bz2
podman-e3cc0717b219c76a417f88a7b905008ff851fab1.zip
podman system df: fix percent calculation
The calculate the percentage we need floating point numbers. The current code however casted the result of reclaimable/size to an int first. Casting to an int in go will just discard the decimal points, thus the result was either 0 or 1 so if multiplied by 100 it would show up as 0% or 100%. To fix this we have to multiply by 100 first before casting the result to an int. Also add a check for div by zero which results in NaN and use math.Round() to correctly round a number. Ref #13516 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'cmd/podman')
-rw-r--r--cmd/podman/system/df.go7
1 files changed, 6 insertions, 1 deletions
diff --git a/cmd/podman/system/df.go b/cmd/podman/system/df.go
index b2325507a..49918487a 100644
--- a/cmd/podman/system/df.go
+++ b/cmd/podman/system/df.go
@@ -2,6 +2,7 @@ package system
import (
"fmt"
+ "math"
"os"
"strings"
"time"
@@ -288,6 +289,10 @@ func (d *dfSummary) Size() string {
}
func (d *dfSummary) Reclaimable() string {
- percent := int(float64(d.reclaimable)/float64(d.size)) * 100
+ percent := 0
+ // make sure to check this to prevent div by zero problems
+ if d.size > 0 {
+ percent = int(math.Round(float64(d.reclaimable) / float64(d.size) * float64(100)))
+ }
return fmt.Sprintf("%s (%d%%)", units.HumanSize(float64(d.reclaimable)), percent)
}