summaryrefslogtreecommitdiff
path: root/cmd/podman
diff options
context:
space:
mode:
authorMatthew Heon <mheon@redhat.com>2018-12-05 09:25:44 -0500
committerMatthew Heon <mheon@redhat.com>2018-12-06 09:10:45 -0500
commite5335fd74c7ed6fe0fa55bf33afbdab23ed687f1 (patch)
tree5b0b13368501604b9180f58aab98682156ced074 /cmd/podman
parentb945d9128a0988ee006a8c743127cf1edc9cb47b (diff)
downloadpodman-e5335fd74c7ed6fe0fa55bf33afbdab23ed687f1.tar.gz
podman-e5335fd74c7ed6fe0fa55bf33afbdab23ed687f1.tar.bz2
podman-e5335fd74c7ed6fe0fa55bf33afbdab23ed687f1.zip
Remove --sync flag from `podman rm`
Per discussion with Dan, it would be better to automatically handle potential runtime errors by automatically syncing if they occur. Retaining the flag for `ps` makes sense, as we won't even be calling the OCI runtime and as such won't see errors if the state desyncs, but rm can be handled automatically. The automatic desync handling code will take some additional work so we'll land this as-is (sync on ps is enough to solve most desync issues). Signed-off-by: Matthew Heon <mheon@redhat.com>
Diffstat (limited to 'cmd/podman')
-rw-r--r--cmd/podman/rm.go10
1 files changed, 0 insertions, 10 deletions
diff --git a/cmd/podman/rm.go b/cmd/podman/rm.go
index 224df4543..7c0569b78 100644
--- a/cmd/podman/rm.go
+++ b/cmd/podman/rm.go
@@ -21,10 +21,6 @@ var (
},
LatestFlag,
cli.BoolFlag{
- Name: "sync",
- Usage: "Sync container state with OCI runtime before removing",
- },
- cli.BoolFlag{
Name: "volumes, v",
Usage: "Remove the volumes associated with the container (Not implemented yet)",
},
@@ -77,12 +73,6 @@ func rmCmd(c *cli.Context) error {
for _, container := range delContainers {
con := container
f := func() error {
- if c.Bool("sync") {
- if err := con.Sync(); err != nil {
- return err
- }
- }
-
return runtime.RemoveContainer(ctx, con, c.Bool("force"))
}