summaryrefslogtreecommitdiff
path: root/cmd/podman
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2021-02-02 16:10:54 -0700
committerEd Santiago <santiago@redhat.com>2021-02-03 05:49:17 -0700
commitdfa9a340ad849637cdc1157f9ec13bac7d789b0e (patch)
treef9781b63e93cc9ee08762dfa10d93f840480083e /cmd/podman
parent4ce8b1281e69b55b6024e87f2dec06638c678f10 (diff)
downloadpodman-dfa9a340ad849637cdc1157f9ec13bac7d789b0e.tar.gz
podman-dfa9a340ad849637cdc1157f9ec13bac7d789b0e.tar.bz2
podman-dfa9a340ad849637cdc1157f9ec13bac7d789b0e.zip
Makefile: make bin/* real targets!
Backstory: every time you run 'make podman' or even just 'make', you get a full recompile. This is sub-ideal. Cause: I don't really know. It looks complicated. #5017 introduced a .PHONY for bin/podman, for reasons not explained in the PR. Then, much later, #5880 well- intentionedly but improperly tweaked the 'find' command used in defining SOURCES, adding a -prune but without the corresponding and required -print. Let's just say, it was an unfortunate cascade of events. This PR fixes the SOURCES definition and removes the highly-undesired .PHONY from podman & podman-remote, making it so you can type 'make' and, oh joy, not build anything if it's current. The way 'make' is supposed to work. Why fix this now? Because my PR (#9209) was failing in CI, in the Validate step: Can't exec "./bin/podman": No such file or directory at hack/xref-helpmsgs-manpages line 223. It failed even on Re-run, and only passed once I force-pushed the PR (with no changes, just a new commit SHA). I have no idea why bin/podman wasn't built, and I have zero interest in pursuing that right now, but the proper solution is to add bin/podman as a Makefile dependency for that particular test. So done. While I'm at it, fix what is pretty clearly a typo in a .PHONY And, finally, fix a go-md2man warning introduced in #9189 [NO TESTS NEEDED] Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'cmd/podman')
0 files changed, 0 insertions, 0 deletions