diff options
| author | Valentin Rothberg <vrothberg@redhat.com> | 2022-05-19 10:45:28 +0200 |
|---|---|---|
| committer | Valentin Rothberg <vrothberg@redhat.com> | 2022-05-19 13:59:15 +0200 |
| commit | b22143267bfd114d23ac25b08b71496f79092a91 (patch) | |
| tree | 09b036d83ce54ed1c0e48ca76781a68f1a1d3ae6 /cmd/podman | |
| parent | 7093885df73989acd2aa2dd936695d0b30a3dcf8 (diff) | |
| download | podman-b22143267bfd114d23ac25b08b71496f79092a91.tar.gz podman-b22143267bfd114d23ac25b08b71496f79092a91.tar.bz2 podman-b22143267bfd114d23ac25b08b71496f79092a91.zip | |
linter: enable unconvert linter
Detects unneccessary type conversions and helps in keeping the code base
cleaner.
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Diffstat (limited to 'cmd/podman')
| -rw-r--r-- | cmd/podman/common/create_test.go | 4 | ||||
| -rw-r--r-- | cmd/podman/containers/kill.go | 2 | ||||
| -rw-r--r-- | cmd/podman/containers/rm.go | 2 | ||||
| -rw-r--r-- | cmd/podman/containers/stop.go | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/cmd/podman/common/create_test.go b/cmd/podman/common/create_test.go index ab41f81ad..80e6cbf54 100644 --- a/cmd/podman/common/create_test.go +++ b/cmd/podman/common/create_test.go @@ -28,8 +28,8 @@ func TestPodOptions(t *testing.T) { for j := 0; j < cc.NumField(); j++ { containerField := cc.FieldByIndex([]int{j}) containerType := reflect.TypeOf(exampleOptions).Field(j) - tagPod := strings.Split(string(podType.Tag.Get("json")), ",")[0] - tagContainer := strings.Split(string(containerType.Tag.Get("json")), ",")[0] + tagPod := strings.Split(podType.Tag.Get("json"), ",")[0] + tagContainer := strings.Split(containerType.Tag.Get("json"), ",")[0] if tagPod == tagContainer && (tagPod != "" && tagContainer != "") { areEqual := true if containerField.Kind() == podField.Kind() { diff --git a/cmd/podman/containers/kill.go b/cmd/podman/containers/kill.go index 32f9899cd..e994fbf2c 100644 --- a/cmd/podman/containers/kill.go +++ b/cmd/podman/containers/kill.go @@ -95,7 +95,7 @@ func kill(_ *cobra.Command, args []string) error { return errors.New("valid signals are 1 through 64") } for _, cidFile := range cidFiles { - content, err := ioutil.ReadFile(string(cidFile)) + content, err := ioutil.ReadFile(cidFile) if err != nil { return errors.Wrap(err, "error reading CIDFile") } diff --git a/cmd/podman/containers/rm.go b/cmd/podman/containers/rm.go index 7e0955863..420e3c38d 100644 --- a/cmd/podman/containers/rm.go +++ b/cmd/podman/containers/rm.go @@ -102,7 +102,7 @@ func rm(cmd *cobra.Command, args []string) error { rmOptions.Timeout = &stopTimeout } for _, cidFile := range cidFiles { - content, err := ioutil.ReadFile(string(cidFile)) + content, err := ioutil.ReadFile(cidFile) if err != nil { return errors.Wrap(err, "error reading CIDFile") } diff --git a/cmd/podman/containers/stop.go b/cmd/podman/containers/stop.go index 381997fee..af2250abb 100644 --- a/cmd/podman/containers/stop.go +++ b/cmd/podman/containers/stop.go @@ -100,7 +100,7 @@ func stop(cmd *cobra.Command, args []string) error { } for _, cidFile := range cidFiles { - content, err := ioutil.ReadFile(string(cidFile)) + content, err := ioutil.ReadFile(cidFile) if err != nil { return errors.Wrap(err, "error reading CIDFile") } |