diff options
| author | Christophe Fergeau <cfergeau@redhat.com> | 2022-07-25 17:10:27 +0200 |
|---|---|---|
| committer | Christophe Fergeau <cfergeau@redhat.com> | 2022-07-26 09:12:27 +0200 |
| commit | 8e56a5605fbcd8c978308985e7f5b08dbdb948ee (patch) | |
| tree | 1baa7482c19f1342395ad3573ef8d3ebb4c9d0c4 /cmd/winpath | |
| parent | e9d29d71cb3185fc071ba4d5f353c9eff6ff349a (diff) | |
| download | podman-8e56a5605fbcd8c978308985e7f5b08dbdb948ee.tar.gz podman-8e56a5605fbcd8c978308985e7f5b08dbdb948ee.tar.bz2 podman-8e56a5605fbcd8c978308985e7f5b08dbdb948ee.zip | |
machine: Fix check which is always true
Before making / mutable/immutable, podman-machine checks if the mount is
being done in /home or /mnt. However the current check is always going
to be true:
```
!strings.HasPrefix(mount.Target, "/home") || !strings.HasPrefix(mount.Target, "/mnt")
```
is false when mount.Target starts with "/home" and mount.Target starts
with "/mnt", which cannot happen at the same time.
The correct check is:
```
!strings.HasPrefix(mount.Target, "/home") && !strings.HasPrefix(mount.Target, "/mnt")
```
which can also be written as:
```
!(strings.HasPrefix(mount.Target, "/home") || strings.HasPrefix(mount.Target, "/mnt"))
```
The impact is not too bad, it results in extra 'chattr -i' calls which
should be unneeded.
[NO NEW TESTS NEEDED]
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Diffstat (limited to 'cmd/winpath')
0 files changed, 0 insertions, 0 deletions