diff options
| author | Ed Santiago <santiago@redhat.com> | 2020-04-29 10:03:12 -0600 |
|---|---|---|
| committer | baude <bbaude@redhat.com> | 2020-04-30 14:55:10 -0500 |
| commit | 91a42fefcbd5372c8701f5a0f5d6da85216cc465 (patch) | |
| tree | aca204c20b52a0911ad3bd4ec9371bf026b92ce9 /cmd | |
| parent | c31bf2e97644b76163624149bb130528c6a5a394 (diff) | |
| download | podman-91a42fefcbd5372c8701f5a0f5d6da85216cc465.tar.gz podman-91a42fefcbd5372c8701f5a0f5d6da85216cc465.tar.bz2 podman-91a42fefcbd5372c8701f5a0f5d6da85216cc465.zip | |
System tests: help messages: check required-arg
If a usage message is of the form '... [flags] ARGNAME',
where ARGNAME is all-caps and not in brackets, it must
be a required argument. Try running podman subcommand
without ARGNAME, and make sure that podman bails out
with an informative message. (Since this message is
freeform in each subcommand, not Cobra-generated,
we have a lot of possible variations to check for).
Fix podman login/logout Use messages to indicate that
REGISTRY is now optional (as of #5233).
This test has actually been in place for over a year but
due to a typo on my part -- a missing space -- it was
not being run. "For want of a space, much testing was lost".
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/podman/login.go | 2 | ||||
| -rw-r--r-- | cmd/podman/logout.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/cmd/podman/login.go b/cmd/podman/login.go index 1843a764d..9de805d15 100644 --- a/cmd/podman/login.go +++ b/cmd/podman/login.go @@ -19,7 +19,7 @@ type loginOptionsWrapper struct { var ( loginOptions = loginOptionsWrapper{} loginCommand = &cobra.Command{ - Use: "login [flags] REGISTRY", + Use: "login [flags] [REGISTRY]", Short: "Login to a container registry", Long: "Login to a container registry on a specified server.", RunE: login, diff --git a/cmd/podman/logout.go b/cmd/podman/logout.go index 77bdc92b4..c21711fc0 100644 --- a/cmd/podman/logout.go +++ b/cmd/podman/logout.go @@ -14,7 +14,7 @@ import ( var ( logoutOptions = auth.LogoutOptions{} logoutCommand = &cobra.Command{ - Use: "logout [flags] REGISTRY", + Use: "logout [flags] [REGISTRY]", Short: "Logout of a container registry", Long: "Remove the cached username and password for the registry.", RunE: logout, |