diff options
author | baude <bbaude@redhat.com> | 2019-08-07 09:09:47 -0500 |
---|---|---|
committer | baude <bbaude@redhat.com> | 2019-08-07 09:10:47 -0500 |
commit | b7b86bda2dea8e0cd6b381ede64d1850f3a5e393 (patch) | |
tree | e81949abac7af31eb0dd956150a37a71c859ede0 /cmd | |
parent | 66ea32cbaf926d59fae3345b7e27a15050ab3afe (diff) | |
download | podman-b7b86bda2dea8e0cd6b381ede64d1850f3a5e393.tar.gz podman-b7b86bda2dea8e0cd6b381ede64d1850f3a5e393.tar.bz2 podman-b7b86bda2dea8e0cd6b381ede64d1850f3a5e393.zip |
fix port early return
when listing multiple ports on a container with podman port, an early
return was limiting results.
Fixes: #3747
Signed-off-by: baude <bbaude@redhat.com>
Diffstat (limited to 'cmd')
-rw-r--r-- | cmd/podman/port.go | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/cmd/podman/port.go b/cmd/podman/port.go index 5753c8e56..4e1f9642c 100644 --- a/cmd/podman/port.go +++ b/cmd/podman/port.go @@ -48,8 +48,8 @@ func init() { func portCmd(c *cliconfig.PortValues) error { var ( - userProto, containerName string - userPort int + userProto string + userPort int ) args := c.InputArgs @@ -106,6 +106,7 @@ func portCmd(c *cliconfig.PortValues) error { if err != nil { return err } + var found bool // Iterate mappings for _, v := range portmappings { hostIP := v.HostIP @@ -125,12 +126,14 @@ func portCmd(c *cliconfig.PortValues) error { if v.ContainerPort == int32(userPort) { if userProto == "" || userProto == v.Protocol { fmt.Printf("%s:%d\n", hostIP, v.HostPort) + found = true break } - } else { - return errors.Errorf("No public port '%d' published for %s", userPort, containerName) } } + if !found && port != "" { + return errors.Errorf("failed to find published port '%d'", userPort) + } } return nil |