summaryrefslogtreecommitdiff
path: root/cmd
diff options
context:
space:
mode:
authorDaniel J Walsh <dwalsh@redhat.com>2021-03-18 06:33:25 -0400
committerDaniel J Walsh <dwalsh@redhat.com>2021-03-24 16:33:30 -0400
commit00949d0bd8a08dcb4d619bebddd1dc3ef3b62e73 (patch)
tree3cc3411a8d46064a41b45aa01c8639807da0714a /cmd
parentaf91f27d85f4104267eea493f8588f8c6a2d01e3 (diff)
downloadpodman-00949d0bd8a08dcb4d619bebddd1dc3ef3b62e73.tar.gz
podman-00949d0bd8a08dcb4d619bebddd1dc3ef3b62e73.tar.bz2
podman-00949d0bd8a08dcb4d619bebddd1dc3ef3b62e73.zip
Check if stdin is a term in --interactive --tty mode
If you are attempting to run a container in interactive mode, and want a --tty, then there must be a terminal in use. Docker exits right away when a user specifies to use a --interactive and --TTY but the stdin is not a tty. Currently podman will pull the image and then fail much later. Podman will continue to run but will print an warning message. Discussion in : https://github.com/containers/podman/issues/8916 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Diffstat (limited to 'cmd')
-rw-r--r--cmd/podman/containers/run.go6
1 files changed, 6 insertions, 0 deletions
diff --git a/cmd/podman/containers/run.go b/cmd/podman/containers/run.go
index 83a5d7b8a..db7180ca9 100644
--- a/cmd/podman/containers/run.go
+++ b/cmd/podman/containers/run.go
@@ -17,6 +17,7 @@ import (
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"github.com/spf13/cobra"
+ "golang.org/x/crypto/ssh/terminal"
)
var (
@@ -106,6 +107,11 @@ func run(cmd *cobra.Command, args []string) error {
return err
}
+ // TODO: Breaking change should be made fatal in next major Release
+ if cliVals.TTY && cliVals.Interactive && !terminal.IsTerminal(int(os.Stdin.Fd())) {
+ logrus.Warnf("The input device is not a TTY. The --tty and --interactive flags might not work properly")
+ }
+
if af := cliVals.Authfile; len(af) > 0 {
if _, err := os.Stat(af); err != nil {
return err