diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2019-08-21 09:24:20 +0200 |
|---|---|---|
| committer | Valentin Rothberg <rothberg@redhat.com> | 2019-08-21 09:41:07 +0200 |
| commit | a33e4a89ca4f689096f417ebddfe5b992470e54d (patch) | |
| tree | 7c48e9644432b199d0ece18d786c513b0c458bf5 /cmd | |
| parent | 1ad8fe52412c8cef215e5a5af312e5db680c3916 (diff) | |
| download | podman-a33e4a89ca4f689096f417ebddfe5b992470e54d.tar.gz podman-a33e4a89ca4f689096f417ebddfe5b992470e54d.tar.bz2 podman-a33e4a89ca4f689096f417ebddfe5b992470e54d.zip | |
generate systemd: drop support for remote clients
Drop the support for remote clients to generate systemd-service files.
The generated files are machine-dependent and hence relate only to the
a local machine. Furthermore, a proper service management when using
a remote-client is not possible as systemd has no access to a process.
Dropping the support will also reduce the risk of making users believe
that the generated services are usable in a remote scenario.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/podman/generate.go | 5 | ||||
| -rw-r--r-- | cmd/podman/varlink/io.podman.varlink | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/cmd/podman/generate.go b/cmd/podman/generate.go index 98bfb00a1..196556bc5 100644 --- a/cmd/podman/generate.go +++ b/cmd/podman/generate.go @@ -18,11 +18,14 @@ var ( // Commands that are universally implemented generateCommands = []*cobra.Command{ _containerKubeCommand, - _containerSystemdCommand, } ) func init() { + // Systemd-service generation is not supported for remote-clients. + if !remoteclient { + generateCommands = append(generateCommands, _containerSystemdCommand) + } generateCommand.Command = _generateCommand generateCommand.AddCommand(generateCommands...) generateCommand.SetUsageTemplate(UsageTemplate()) diff --git a/cmd/podman/varlink/io.podman.varlink b/cmd/podman/varlink/io.podman.varlink index 1b10416a2..2873d9761 100644 --- a/cmd/podman/varlink/io.podman.varlink +++ b/cmd/podman/varlink/io.podman.varlink @@ -1241,8 +1241,6 @@ method GetLayersMapWithImageInfo() -> (layerMap: string) # BuildImageHierarchyMap is for the development of Podman and should not be used. method BuildImageHierarchyMap(name: string) -> (imageInfo: string) -method GenerateSystemd(name: string, restart: string, timeout: int, useName: bool) -> (unit: string) - # ImageNotFound means the image could not be found by the provided name or ID in local storage. error ImageNotFound (id: string, reason: string) |