diff options
author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2021-10-05 05:32:50 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-05 05:32:50 -0400 |
commit | 4965efe1f67c4051ef878c56c10110072f1fb757 (patch) | |
tree | 1e398efe2bbcc50f481eaf8d6a588c809aa46771 /contrib/cirrus/pr-should-include-tests | |
parent | c963a500909055db3890c42b10d7bb55f379031d (diff) | |
parent | 521c0cbd1cab18cd3df12bb052d4db23c81478fc (diff) | |
download | podman-4965efe1f67c4051ef878c56c10110072f1fb757.tar.gz podman-4965efe1f67c4051ef878c56c10110072f1fb757.tar.bz2 podman-4965efe1f67c4051ef878c56c10110072f1fb757.zip |
Merge pull request #11861 from edsantiago/no_new_tests_needed
It really should be no **NEW** tests needed
Diffstat (limited to 'contrib/cirrus/pr-should-include-tests')
-rwxr-xr-x | contrib/cirrus/pr-should-include-tests | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/contrib/cirrus/pr-should-include-tests b/contrib/cirrus/pr-should-include-tests index 09ab002cf..4b6329311 100755 --- a/contrib/cirrus/pr-should-include-tests +++ b/contrib/cirrus/pr-should-include-tests @@ -8,7 +8,10 @@ if [[ "${CIRRUS_CHANGE_TITLE}" =~ CI:DOCS ]]; then exit 0 fi -# So are PRs where 'NO TESTS NEEDED' appears in the Github message +# So are PRs where 'NO NEW TESTS NEEDED' appears in the Github message +if [[ "${CIRRUS_CHANGE_MESSAGE}" =~ NO.NEW.TESTS.NEEDED ]]; then + exit 0 +fi if [[ "${CIRRUS_CHANGE_MESSAGE}" =~ NO.TESTS.NEEDED ]]; then exit 0 fi @@ -49,8 +52,11 @@ if [[ -z "$filtered_changes" ]]; then exit 0 fi -# One last chance: perhaps the developer included the magic '[NO TESTS NEEDED]' +# One last chance: perhaps the developer included the magic '[NO (NEW) TESTS NEEDED]' # string in an amended commit. +if git log --format=%B ${base}..${head} | fgrep '[NO NEW TESTS NEEDED]'; then + exit 0 +fi if git log --format=%B ${base}..${head} | fgrep '[NO TESTS NEEDED]'; then exit 0 fi @@ -67,7 +73,7 @@ tests, possibly just adding a small step to a similar existing test. Every second counts in CI. If your commit really, truly does not need tests, you can proceed -by adding '[NO TESTS NEEDED]' to the body of your commit message. +by adding '[NO NEW TESTS NEEDED]' to the body of your commit message. Please think carefully before doing so. EOF |