diff options
| author | Ed Santiago <santiago@redhat.com> | 2021-10-04 19:12:58 -0600 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2021-10-04 19:23:38 -0600 |
| commit | 521c0cbd1cab18cd3df12bb052d4db23c81478fc (patch) | |
| tree | 1e398efe2bbcc50f481eaf8d6a588c809aa46771 /contrib/cirrus/pr-should-include-tests | |
| parent | c963a500909055db3890c42b10d7bb55f379031d (diff) | |
| download | podman-521c0cbd1cab18cd3df12bb052d4db23c81478fc.tar.gz podman-521c0cbd1cab18cd3df12bb052d4db23c81478fc.tar.bz2 podman-521c0cbd1cab18cd3df12bb052d4db23c81478fc.zip | |
It really should be no **NEW** tests needed
Accept both "NO TESTS NEEDED" and "NO NEW TESTS NEEDED".
That was a usability mistake I made on Day One. Fixed it
in Buildah but oops never got around to fixing it here.
Also, fix the test suite script: remove a no-longer-working
test case (changelog.txt, removed in #11467) and add a new
test for commits that include the magic string.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'contrib/cirrus/pr-should-include-tests')
| -rwxr-xr-x | contrib/cirrus/pr-should-include-tests | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/contrib/cirrus/pr-should-include-tests b/contrib/cirrus/pr-should-include-tests index 09ab002cf..4b6329311 100755 --- a/contrib/cirrus/pr-should-include-tests +++ b/contrib/cirrus/pr-should-include-tests @@ -8,7 +8,10 @@ if [[ "${CIRRUS_CHANGE_TITLE}" =~ CI:DOCS ]]; then exit 0 fi -# So are PRs where 'NO TESTS NEEDED' appears in the Github message +# So are PRs where 'NO NEW TESTS NEEDED' appears in the Github message +if [[ "${CIRRUS_CHANGE_MESSAGE}" =~ NO.NEW.TESTS.NEEDED ]]; then + exit 0 +fi if [[ "${CIRRUS_CHANGE_MESSAGE}" =~ NO.TESTS.NEEDED ]]; then exit 0 fi @@ -49,8 +52,11 @@ if [[ -z "$filtered_changes" ]]; then exit 0 fi -# One last chance: perhaps the developer included the magic '[NO TESTS NEEDED]' +# One last chance: perhaps the developer included the magic '[NO (NEW) TESTS NEEDED]' # string in an amended commit. +if git log --format=%B ${base}..${head} | fgrep '[NO NEW TESTS NEEDED]'; then + exit 0 +fi if git log --format=%B ${base}..${head} | fgrep '[NO TESTS NEEDED]'; then exit 0 fi @@ -67,7 +73,7 @@ tests, possibly just adding a small step to a similar existing test. Every second counts in CI. If your commit really, truly does not need tests, you can proceed -by adding '[NO TESTS NEEDED]' to the body of your commit message. +by adding '[NO NEW TESTS NEEDED]' to the body of your commit message. Please think carefully before doing so. EOF |