Cirrus: Fix branch-validation failure

When validating code on a branch, determining a starting commit to check
from isn't as straightforward as it would seem.  Default to using the
SHA from last time CI was green.  If for some reason that isn't
available, use an obviously wrong value to cause an intentional
failure.  Entirely skip this check on tag-push, since determining a
starting point is incredibly difficult to do automatically.

Signed-off-by: Chris Evich <cevich@redhat.com>

1 files changed, 7 insertions, 1 deletions

diff --git a/contrib/cirrus/runner.sh b/contrib/cirrus/runner.sh
index 82e512de9..17bb05019 100755
--- a/contrib/cirrus/runner.sh
+++ b/contrib/cirrus/runner.sh
@@ -179,7 +179,13 @@ case "$TEST_FLAVOR" in
     ext_svc) $SCRIPT_BASE/ext_svc_check.sh ;;
     smoke)
         make gofmt
-        make .gitvalidation
+        # There is little value to validating commits after tag-push
+        # and it's very difficult to automatically determine a starting commit.
+        # $CIRRUS_TAG is only non-empty when executing due to a tag-push
+        # shellcheck disable=SC2154
+        if [[ -z "$CIRRUS_TAG" ]]; then
+            make .gitvalidation
+        fi
         ;;
     automation)
         $SCRIPT_BASE/cirrus_yaml_test.py