summaryrefslogtreecommitdiff
path: root/contrib/cirrus/system_test.sh
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2019-05-02 05:49:50 -0600
committerEd Santiago <santiago@redhat.com>2019-05-02 08:14:59 -0600
commit295c531ecec8661408f01ac4e015d75fec865376 (patch)
tree207a92de67c76264dc4563588e84a261facb8570 /contrib/cirrus/system_test.sh
parent7d05ff3fc772a7be4860ed4a3cd59a62f8bb893a (diff)
downloadpodman-295c531ecec8661408f01ac4e015d75fec865376.tar.gz
podman-295c531ecec8661408f01ac4e015d75fec865376.tar.bz2
podman-295c531ecec8661408f01ac4e015d75fec865376.zip
cirrus lib.sh: refactor req_env_var()
Existing code was not working due to a bash gotcha ('exit' from a pipeline). It also had unnecessary duplication. New version is safer; also includes unit tests run under localunit. Existing invocations of req_env_var replaced via: $ [ edit setup_environment.sh, move one closing quote to its own line ] $ perl -ni -e 's/(?<=req_env_var )"(\S+)\s+\$\1"/$1/; if (/req_env_var "$/ .. /^\s*"/) { chomp; s/(?<=\S)\s.*//; if (/^\s*"/) { print "\n" } else { unless (/req_env_var/) { s/^\s+//; print " ";} print;} } else { print }' $(ack -l req_env_var) $ [ hand-massage an incorrect instance of '@' in lib.sh:ircmsg() ] Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'contrib/cirrus/system_test.sh')
-rwxr-xr-xcontrib/cirrus/system_test.sh6
1 files changed, 1 insertions, 5 deletions
diff --git a/contrib/cirrus/system_test.sh b/contrib/cirrus/system_test.sh
index cb179407a..dd5ef511d 100755
--- a/contrib/cirrus/system_test.sh
+++ b/contrib/cirrus/system_test.sh
@@ -3,11 +3,7 @@
set -e
source $(dirname $0)/lib.sh
-req_env_var "
-GOSRC $GOSRC
-OS_RELEASE_ID $OS_RELEASE_ID
-OS_RELEASE_VER $OS_RELEASE_VER
-"
+req_env_var GOSRC OS_RELEASE_ID OS_RELEASE_VER
clean_env