diff options
| author | Ed Santiago <santiago@redhat.com> | 2022-09-21 14:33:18 -0600 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2022-09-27 05:52:34 -0600 |
| commit | 0fb95f95d2af7bcc2529f896fec9904b3357b580 (patch) | |
| tree | da40582be1a46cee1cc6fa6decc427a8185e24f0 /hack | |
| parent | f51aeb45d497379b6e0a11414d69435e83908efa (diff) | |
| download | podman-0fb95f95d2af7bcc2529f896fec9904b3357b580.tar.gz podman-0fb95f95d2af7bcc2529f896fec9904b3357b580.tar.bz2 podman-0fb95f95d2af7bcc2529f896fec9904b3357b580.zip | |
CI: only make install.tools when needed
Reintroduce .install.foo targets into Makefile, and invoke
only the bare-minimum ones needed for each individual CI
step in setup_environment.sh.
Also add a retry to the golangci-lint curl, in hopes of
dealing with network flakes. And remove the -f (fail)
because it produces unhelpful logs.
Reason: saw about 25% CI flakes yesterday due to the golangci-lint
fetch, something about a timeout, and this was especially frustrating
because none of the steps actually needed lint. Quick reminder:
avoid network fetches unless absolutely necessary.
Fixes: #15892
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'hack')
| -rwxr-xr-x | hack/install_golangci.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hack/install_golangci.sh b/hack/install_golangci.sh index 896d59901..29d925666 100755 --- a/hack/install_golangci.sh +++ b/hack/install_golangci.sh @@ -6,7 +6,7 @@ die() { echo "${1:-No error message given} (from $(basename $0))"; exit 1; } function install() { echo "Installing golangci-lint v$VERSION into $BIN" - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v$VERSION + curl -sSL --retry 5 https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v$VERSION } # Undocumented behavior: golangci-lint installer requires $BINDIR in env, |