diff options
author | Valentin Rothberg <rothberg@redhat.com> | 2021-01-17 17:07:04 +0100 |
---|---|---|
committer | Valentin Rothberg <rothberg@redhat.com> | 2021-01-17 17:07:04 +0100 |
commit | f38b7f48cc46215de1d23a4882b4b6f5ac85ad69 (patch) | |
tree | a53fb123822051a8ebd8155165edec31ea820855 /hack | |
parent | 341c4b1fd94dda26be5ce588490e3d7284a54dbb (diff) | |
download | podman-f38b7f48cc46215de1d23a4882b4b6f5ac85ad69.tar.gz podman-f38b7f48cc46215de1d23a4882b4b6f5ac85ad69.tar.bz2 podman-f38b7f48cc46215de1d23a4882b4b6f5ac85ad69.zip |
golangci-lint: install to ./bin
Install golangci-lint to `./bin` instead of `$GOBIN`. The latter may be
shared with other projects who require a different version. Having a
shared version of golangci-lint is a reoccurring source of red herrings
on my work station, so I think it's time to split them.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'hack')
-rwxr-xr-x | hack/golangci-lint.sh | 2 | ||||
-rwxr-xr-x | hack/install_golangci.sh | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/hack/golangci-lint.sh b/hack/golangci-lint.sh index 50bf29bb8..5be750129 100755 --- a/hack/golangci-lint.sh +++ b/hack/golangci-lint.sh @@ -21,5 +21,5 @@ for i in tunnel abi; do echo Running golangci-lint for "$i" echo Build Tags "$i": ${BUILD_TAGS[$i]} echo Skipped directories "$i": ${SKIP_DIRS[$i]} - golangci-lint run --build-tags=${BUILD_TAGS[$i]} --skip-dirs=${SKIP_DIRS[$i]} "$@" + ./bin/golangci-lint run --build-tags=${BUILD_TAGS[$i]} --skip-dirs=${SKIP_DIRS[$i]} "$@" done diff --git a/hack/install_golangci.sh b/hack/install_golangci.sh index 617679751..a962df6e1 100755 --- a/hack/install_golangci.sh +++ b/hack/install_golangci.sh @@ -7,10 +7,10 @@ die() { echo "${1:-No error message given} (from $(basename $0))"; exit 1; } [ -n "$VERSION" ] || die "\$VERSION is empty or undefined" [ -n "$GOBIN" ] || die "\$GOBIN is empty or undefined" -BIN="$GOBIN/golangci-lint" +BIN="./bin/golangci-lint" if [ ! -x "$BIN" ]; then - echo "Installing golangci-lint v$VERSION into $GOBIN" - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $GOBIN v$VERSION + echo "Installing golangci-lint v$VERSION into $BIN" + curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b ./bin v$VERSION else # Prints its own file name as part of --version output echo "Using existing $(dirname $BIN)/$($BIN --version)" |