diff options
| author | Daniel J Walsh <dwalsh@redhat.com> | 2020-12-01 14:07:18 -0500 |
|---|---|---|
| committer | Daniel J Walsh <dwalsh@redhat.com> | 2020-12-01 14:11:04 -0500 |
| commit | c734c13904d40d40c2cc13ec55b8a6397af2db67 (patch) | |
| tree | e3ce9ea69cef3f39d451f2ffb0a50b14af61dfd2 /libpod/common_test.go | |
| parent | 429d9492f85faf4c3a595b9d7b2a38743a4b8e42 (diff) | |
| download | podman-c734c13904d40d40c2cc13ec55b8a6397af2db67.tar.gz podman-c734c13904d40d40c2cc13ec55b8a6397af2db67.tar.bz2 podman-c734c13904d40d40c2cc13ec55b8a6397af2db67.zip | |
Fix potential race condition in testing
The It("podman wait to pause|unpause condition"... test is
flaking every so often when a messages is sent in the second
function to a channel. It is my believe that in between the time
the first function sends a message to the channel and before it closes
the channel the second errChan=make() has happened. This would mean that
the fist function closes the second errChan, and then when the second
function sends a message to the second errChan, it fails and blows up with
the error you are seeing.
By creating a different variable for the second channel, we eliminate the race.
Fixes: https://github.com/containers/podman/issues/6518
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Diffstat (limited to 'libpod/common_test.go')
0 files changed, 0 insertions, 0 deletions