diff options
author | baude <bbaude@redhat.com> | 2019-02-13 13:22:58 -0600 |
---|---|---|
committer | baude <bbaude@redhat.com> | 2019-02-13 13:51:23 -0600 |
commit | dd74467fd8dcbdab35b4c7fc2dc183d12fb228f2 (patch) | |
tree | 647d88b335a6da3e6fbdf481694223fd9b7c8026 /libpod/container.go | |
parent | 8a16f83b0a13ab9de1cc905a3ff1132c75739995 (diff) | |
download | podman-dd74467fd8dcbdab35b4c7fc2dc183d12fb228f2.tar.gz podman-dd74467fd8dcbdab35b4c7fc2dc183d12fb228f2.tar.bz2 podman-dd74467fd8dcbdab35b4c7fc2dc183d12fb228f2.zip |
show container ports of network namespace
in cases where a container is part of a network namespace, we should
show the network namespace's ports when dealing with ports. this
impacts ps, kube, and port.
fixes: #846
Signed-off-by: baude <bbaude@redhat.com>
Diffstat (limited to 'libpod/container.go')
-rw-r--r-- | libpod/container.go | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/libpod/container.go b/libpod/container.go index b0589be3b..fec61533d 100644 --- a/libpod/container.go +++ b/libpod/container.go @@ -557,8 +557,16 @@ func (c *Container) NewNetNS() bool { // PortMappings returns the ports that will be mapped into a container if // a new network namespace is created // If NewNetNS() is false, this value is unused -func (c *Container) PortMappings() []ocicni.PortMapping { - return c.config.PortMappings +func (c *Container) PortMappings() ([]ocicni.PortMapping, error) { + // First check if the container belongs to a network namespace (like a pod) + if len(c.config.NetNsCtr) > 0 { + netNsCtr, err := c.runtime.LookupContainer(c.config.NetNsCtr) + if err != nil { + return nil, errors.Wrapf(err, "unable to lookup network namespace for container %s", c.ID()) + } + return netNsCtr.PortMappings() + } + return c.config.PortMappings, nil } // DNSServers returns DNS servers that will be used in the container's |