summaryrefslogtreecommitdiff
path: root/libpod/container.go
diff options
context:
space:
mode:
authorValentin Rothberg <rothberg@redhat.com>2021-09-29 10:58:27 +0200
committerValentin Rothberg <rothberg@redhat.com>2021-09-29 13:44:39 +0200
commit98176f001863fd138025c48625eda5c5adb26972 (patch)
treebc4be5ce8379ee9f6d9da1b96cf66f82f22cdae7 /libpod/container.go
parent453c49c488dd6518b33393e04c04ebc32ce61ee9 (diff)
downloadpodman-98176f001863fd138025c48625eda5c5adb26972.tar.gz
podman-98176f001863fd138025c48625eda5c5adb26972.tar.bz2
podman-98176f001863fd138025c48625eda5c5adb26972.zip
libpod: do not call (*container).Spec()
Access the container's spec field directly inside of libpod instead of calling Spec() which in turn creates expensive JSON deep copies. Accessing the field directly drops memory consumption of a simple podman run --rm busybox true from ~700kB to ~600kB. [NO TESTS NEEDED] Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'libpod/container.go')
-rw-r--r--libpod/container.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/libpod/container.go b/libpod/container.go
index 5c56ff036..ffc577950 100644
--- a/libpod/container.go
+++ b/libpod/container.go
@@ -1095,7 +1095,7 @@ func (c *Container) AutoRemove() bool {
if spec.Annotations == nil {
return false
}
- return c.Spec().Annotations[define.InspectAnnotationAutoremove] == define.InspectResponseTrue
+ return spec.Annotations[define.InspectAnnotationAutoremove] == define.InspectResponseTrue
}
// Timezone returns the timezone configured inside the container.