diff options
| author | Matthew Heon <matthew.heon@pm.me> | 2019-10-15 15:11:26 -0400 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2019-10-15 15:59:20 -0400 |
| commit | cab7bfbb211f2496af9f86208588e26954fc9b2a (patch) | |
| tree | d65c78bbac71bba5dc7a1b95b830a9d032243f87 /libpod/container_api.go | |
| parent | 5f72e6ef2ef7b6941cefc3c655903aeacb53e115 (diff) | |
| download | podman-cab7bfbb211f2496af9f86208588e26954fc9b2a.tar.gz podman-cab7bfbb211f2496af9f86208588e26954fc9b2a.tar.bz2 podman-cab7bfbb211f2496af9f86208588e26954fc9b2a.zip | |
Add a MissingRuntime implementation
When a container is created with a given OCI runtime, but then it
is uninstalled or removed from the configuration file, Libpod
presently reacts very poorly. The EvictContainer code can
potentially remove these containers, but we still can't see them
in `podman ps` (aside from the massive logrus.Errorf messages
they create).
Providing a minimal OCI runtime implementation for missing
runtimes allows us to behave better. We'll be able to retrieve
containers from the database, though we still pop up an error for
each missing runtime. For containers which are stopped, we can
remove them as normal.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'libpod/container_api.go')
| -rw-r--r-- | libpod/container_api.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libpod/container_api.go b/libpod/container_api.go index 04c796410..759a7067e 100644 --- a/libpod/container_api.go +++ b/libpod/container_api.go @@ -656,7 +656,7 @@ func (c *Container) Sync() error { (c.state.State != define.ContainerStateConfigured) && (c.state.State != define.ContainerStateExited) { oldState := c.state.State - if err := c.ociRuntime.UpdateContainerStatus(c, true); err != nil { + if err := c.ociRuntime.UpdateContainerStatus(c); err != nil { return err } // Only save back to DB if state changed |