diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2021-03-05 10:33:27 +0100 |
|---|---|---|
| committer | Valentin Rothberg <rothberg@redhat.com> | 2021-03-09 09:02:14 +0100 |
| commit | 2abfef3809abc59e8d29bcbcf2b5e0aa7141fb6d (patch) | |
| tree | b47cb84b59dbafc9f90ca08474795b35fc824bf7 /libpod/container_copy_linux.go | |
| parent | d175fbfdb460315d2a3f8b0c679101b604411ef8 (diff) | |
| download | podman-2abfef3809abc59e8d29bcbcf2b5e0aa7141fb6d.tar.gz podman-2abfef3809abc59e8d29bcbcf2b5e0aa7141fb6d.tar.bz2 podman-2abfef3809abc59e8d29bcbcf2b5e0aa7141fb6d.zip | |
podman cp: ignore EPERMs in rootless mode
Ignore permission errors when copying from a rootless container.
TTY devices inside rootless containers are owned by the host's
root user which is "nobody" inside the container's user namespace
rendering us unable to even read them.
Enable the integration test which was temporarily disabled for rootless
users.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'libpod/container_copy_linux.go')
| -rw-r--r-- | libpod/container_copy_linux.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/libpod/container_copy_linux.go b/libpod/container_copy_linux.go index 66ccd2f1f..9dd7e7e9c 100644 --- a/libpod/container_copy_linux.go +++ b/libpod/container_copy_linux.go @@ -14,6 +14,7 @@ import ( "github.com/containers/buildah/pkg/chrootuser" "github.com/containers/buildah/util" "github.com/containers/podman/v3/libpod/define" + "github.com/containers/podman/v3/pkg/rootless" "github.com/containers/storage" "github.com/containers/storage/pkg/idtools" "github.com/docker/docker/pkg/archive" @@ -139,6 +140,11 @@ func (c *Container) copyToArchive(ctx context.Context, path string, writer io.Wr ChownDirs: idPair, ChownFiles: idPair, Excludes: []string{"dev", "proc", "sys"}, + // Ignore EPERMs when copying from rootless containers + // since we cannot read TTY devices. Those are owned + // by the host's root and hence "nobody" inside the + // container's user namespace. + IgnoreUnreadable: rootless.IsRootless() && c.state.State == define.ContainerStateRunning, } return c.joinMountAndExec(ctx, func() error { |