diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2021-09-28 17:01:22 +0200 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2021-09-29 16:39:29 -0400 |
| commit | ba74d6e6ecc2cc8e1480a466e29a078a93e24afa (patch) | |
| tree | c5051bfcdcdc6363d1b4dabfa71eb7132500bd64 /libpod/container_copy_linux.go | |
| parent | a1199dbaf1e42de665a8fc40ba0dd17d21f05ab7 (diff) | |
| download | podman-ba74d6e6ecc2cc8e1480a466e29a078a93e24afa.tar.gz podman-ba74d6e6ecc2cc8e1480a466e29a078a93e24afa.tar.bz2 podman-ba74d6e6ecc2cc8e1480a466e29a078a93e24afa.zip | |
libpod: do not call (*container).Config()
Access the container's config field directly inside of libpod instead of
calling `Config()` which in turn creates expensive JSON deep copies.
Accessing the field directly drops memory consumption of a simple
`podman run --rm busybox true` from 1245kB to 410kB.
[NO TESTS NEEDED]
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
<MH: Fixed cherry-pick conflicts>
Diffstat (limited to 'libpod/container_copy_linux.go')
| -rw-r--r-- | libpod/container_copy_linux.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libpod/container_copy_linux.go b/libpod/container_copy_linux.go index a35824289..7d4dd0d46 100644 --- a/libpod/container_copy_linux.go +++ b/libpod/container_copy_linux.go @@ -174,7 +174,7 @@ func (c *Container) copyToArchive(ctx context.Context, path string, writer io.Wr // getContainerUser returns the specs.User and ID mappings of the container. func getContainerUser(container *Container, mountPoint string) (specs.User, error) { - userspec := container.Config().User + userspec := container.config.User uid, gid, _, err := chrootuser.GetUser(mountPoint, userspec) u := specs.User{ |