diff options
author | Matthew Heon <matthew.heon@pm.me> | 2020-05-14 16:31:55 -0400 |
---|---|---|
committer | Matthew Heon <matthew.heon@pm.me> | 2020-05-14 16:56:02 -0400 |
commit | 0f0abe290927cd17542953042885b554dbffd83e (patch) | |
tree | 202857ba4b7586744a194fecb73af65b8380f466 /libpod/container_exec.go | |
parent | 0c3bed119b16e90534172410f70713591ecafc4c (diff) | |
download | podman-0f0abe290927cd17542953042885b554dbffd83e.tar.gz podman-0f0abe290927cd17542953042885b554dbffd83e.tar.bz2 podman-0f0abe290927cd17542953042885b554dbffd83e.zip |
Prune stale exec sessions on inspect
The usual flow for exec is going to be:
- Create exec session
- Start and attach to exec session
- Exec session exits, attach session terminates
- Client does an exec inspect to pick up exit code
The safest point to remove the exec session, without doing any
database changes to track stale sessions, is to remove during the
last part of this - the single inspect after the exec session
exits.
This is definitely different from Docker (which would retain the
exec session for up to 10 minutes after it exits, where we will
immediately discard) but should be close enough to be not
noticeable in regular usage.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'libpod/container_exec.go')
-rw-r--r-- | libpod/container_exec.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libpod/container_exec.go b/libpod/container_exec.go index 979594eb4..6ad767b4b 100644 --- a/libpod/container_exec.go +++ b/libpod/container_exec.go @@ -104,7 +104,7 @@ func (e *ExecSession) Inspect() (*define.InspectExecSession, error) { } output := new(define.InspectExecSession) - output.CanRemove = e.State != define.ExecStateRunning + output.CanRemove = e.State == define.ExecStateStopped output.ContainerID = e.ContainerId if e.Config.DetachKeys != nil { output.DetachKeys = *e.Config.DetachKeys |