diff options
| author | Matthew Heon <mheon@redhat.com> | 2022-05-23 13:27:04 -0400 |
|---|---|---|
| committer | Matthew Heon <mheon@redhat.com> | 2022-05-25 13:28:04 -0400 |
| commit | 9fcfea7643b243a3ad691daaf07fe358f85491cb (patch) | |
| tree | 394d7d646b73b8b1dee8683d2485adfe7ade0203 /libpod/container_internal_linux.go | |
| parent | 819e5bcb943c6f604fdc65be1c0387055e0a9f20 (diff) | |
| download | podman-9fcfea7643b243a3ad691daaf07fe358f85491cb.tar.gz podman-9fcfea7643b243a3ad691daaf07fe358f85491cb.tar.bz2 podman-9fcfea7643b243a3ad691daaf07fe358f85491cb.zip | |
First batch of resolutions to FIXMEs
Most of these are no longer relevant, just drop the comments.
Most notable change: allow `podman kill` on paused containers.
Works just fine when I test it.
Signed-off-by: Matthew Heon <mheon@redhat.com>
Diffstat (limited to 'libpod/container_internal_linux.go')
| -rw-r--r-- | libpod/container_internal_linux.go | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/libpod/container_internal_linux.go b/libpod/container_internal_linux.go index 298eb1947..e19d75deb 100644 --- a/libpod/container_internal_linux.go +++ b/libpod/container_internal_linux.go @@ -1091,7 +1091,6 @@ func (c *Container) addNamespaceContainer(g *generate.Generator, ns LinuxNS, ctr g.AddProcessEnv("HOSTNAME", hostname) } - // TODO need unlocked version of this for use in pods nsPath, err := nsCtr.NamespacePath(ns) if err != nil { return err @@ -3230,10 +3229,8 @@ func (c *Container) fixVolumePermissions(v *ContainerNamedVolume) error { return err } - // TODO: For now, I've disabled chowning volumes owned by non-Podman - // drivers. This may be safe, but it's really going to be a case-by-case - // thing, I think - safest to leave disabled now and re-enable later if - // there is a demand. + // Volumes owned by a volume driver are not chowned - we don't want to + // mess with a mount not managed by us. if vol.state.NeedsChown && !vol.UsesVolumeDriver() { vol.state.NeedsChown = false |