summaryrefslogtreecommitdiff
path: root/libpod/define/errors.go
diff options
context:
space:
mode:
authorMatthew Heon <matthew.heon@pm.me>2020-07-02 12:59:10 -0400
committerMatthew Heon <matthew.heon@pm.me>2020-07-02 12:59:10 -0400
commite996bb583d92c746dea36c71c3f747077271b75f (patch)
tree3771a4af5370fd52432e7e54181fe122d85fddbc /libpod/define/errors.go
parentc131567401bea2867d597d79cce75b99012e64fb (diff)
downloadpodman-e996bb583d92c746dea36c71c3f747077271b75f.tar.gz
podman-e996bb583d92c746dea36c71c3f747077271b75f.tar.bz2
podman-e996bb583d92c746dea36c71c3f747077271b75f.zip
Print errors from individual containers in pods
The infra/abi code for pods was written in a flawed way, assuming that the map[string]error containing individual container errors was only set when the global error for the pod function was nil; that is not accurate, and we are actually *guaranteed* to set the global error when any individual container errors. Thus, we'd never actually include individual container errors, because the infra code assumed that err being set meant everything failed and no container operations were attempted. We were originally setting the cause of the error to something nonsensical ("container already exists"), so I made a new error indicating that some containers in the pod failed. We can then ignore that error when building the report on the pod operation and actually return errors from individual containers. Unfortunately, this exposed another weakness of the infra code, which was discarding the container IDs. Errors from individual containers are not guaranteed to identify which container they came from, hence the use of map[string]error in the Pod API functions. Rather than restructuring the structs we return from pkg/infra, I just wrapped the returned errors with a message including the ID of the container. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'libpod/define/errors.go')
-rw-r--r--libpod/define/errors.go4
1 files changed, 4 insertions, 0 deletions
diff --git a/libpod/define/errors.go b/libpod/define/errors.go
index 98dc603d1..200c7e3d4 100644
--- a/libpod/define/errors.go
+++ b/libpod/define/errors.go
@@ -70,6 +70,10 @@ var (
// ErrInternal indicates an internal library error
ErrInternal = errors.New("internal libpod error")
+ // ErrPodPartialFail indicates that a pod operation was only partially
+ // successful, and some containers within the pod failed.
+ ErrPodPartialFail = errors.New("some containers failed")
+
// ErrDetach indicates that an attach session was manually detached by
// the user.
ErrDetach = utils.ErrDetach