diff options
author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2021-02-12 13:32:00 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-02-12 13:32:00 -0500 |
commit | 1d15ed708f2d7c6dab5ee90415acb156973ac1a4 (patch) | |
tree | 874871fe3589b0bf45ca84ceedd0276164fcfde3 /libpod/image/layer_tree.go | |
parent | 73cf06a453a60966616926d17ad4e89cef0e1dec (diff) | |
parent | adfcb74602dcefb64fad226d4f949e5ee98ea324 (diff) | |
download | podman-1d15ed708f2d7c6dab5ee90415acb156973ac1a4.tar.gz podman-1d15ed708f2d7c6dab5ee90415acb156973ac1a4.tar.bz2 podman-1d15ed708f2d7c6dab5ee90415acb156973ac1a4.zip |
Merge pull request #9341 from vrothberg/layer-tree-errors
make layer-tree lookup errors non-fatal
Diffstat (limited to 'libpod/image/layer_tree.go')
-rw-r--r-- | libpod/image/layer_tree.go | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/libpod/image/layer_tree.go b/libpod/image/layer_tree.go index 18101575e..dde39dba1 100644 --- a/libpod/image/layer_tree.go +++ b/libpod/image/layer_tree.go @@ -5,6 +5,7 @@ import ( ociv1 "github.com/opencontainers/image-spec/specs-go/v1" "github.com/pkg/errors" + "github.com/sirupsen/logrus" ) // layerTree is an internal representation of local layers. @@ -84,7 +85,12 @@ func (ir *Runtime) layerTree() (*layerTree, error) { } node, exists := tree.nodes[topLayer] if !exists { - return nil, errors.Errorf("top layer %s of image %s not found in layer tree", img.TopLayer(), img.ID()) + // Note: erroring out in this case has turned out having been a + // mistake. Users may not be able to recover, so we're now + // throwing a warning to guide them to resolve the issue and + // turn the errors non-fatal. + logrus.Warnf("Top layer %s of image %s not found in layer tree. The storage may be corrupted, consider running `podman system reset`.", topLayer, img.ID()) + continue } node.images = append(node.images, img) } @@ -107,7 +113,12 @@ func (t *layerTree) children(ctx context.Context, parent *Image, all bool) ([]st parentNode, exists := t.nodes[parent.TopLayer()] if !exists { - return nil, errors.Errorf("layer not found in layer tree: %q", parent.TopLayer()) + // Note: erroring out in this case has turned out having been a + // mistake. Users may not be able to recover, so we're now + // throwing a warning to guide them to resolve the issue and + // turn the errors non-fatal. + logrus.Warnf("Layer %s not found in layer. The storage may be corrupted, consider running `podman system reset`.", parent.TopLayer()) + return children, nil } parentID := parent.ID() |