diff options
author | Miloslav Trmač <mitr@redhat.com> | 2019-01-14 03:49:08 +0100 |
---|---|---|
committer | Miloslav Trmač <mitr@redhat.com> | 2019-01-14 03:55:44 +0100 |
commit | a6e668fac54b8dcc34b9810738b22fa7c8561325 (patch) | |
tree | 996fb1c9eb984dee1f5fa730334b524627137d07 /libpod/image/parts_test.go | |
parent | 140ae25c4d0c7ba89a0bb7ae16f81f90d20be535 (diff) | |
download | podman-a6e668fac54b8dcc34b9810738b22fa7c8561325.tar.gz podman-a6e668fac54b8dcc34b9810738b22fa7c8561325.tar.bz2 podman-a6e668fac54b8dcc34b9810738b22fa7c8561325.zip |
Don't call image.DecomposeString in imageInListToContainerImage
- It is used to fill Repository(misnamed)/Tag members which have no users;
so it's completely unclear why this is useful.
- Given the mishandling of tags by imageParts.tag, at the very least
all new code should primarily use reference.Named (even if
after a decompose() to internally deal with unqualified names first),
introducing new uses of original decompose() just reintroduces known
trouble - so without any provided rationale, reverting seems
a reasonable default action.
- This drags in all of libpod/image into the "remote client" build,
which seems undesirable.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Diffstat (limited to 'libpod/image/parts_test.go')
0 files changed, 0 insertions, 0 deletions