diff options
| author | Miloslav Trmač <mitr@redhat.com> | 2018-08-01 23:05:20 +0200 |
|---|---|---|
| committer | Atomic Bot <atomic-devel@projectatomic.io> | 2018-08-02 13:17:17 +0000 |
| commit | be101dee8af7233c8907a0f6cf06ad2a20575ed6 (patch) | |
| tree | b80be9540be03aa4e505952dabd0802ab457a016 /libpod/image/pull.go | |
| parent | a6de23278a6e5b7f27c093eb19c201b77b7c4416 (diff) | |
| download | podman-be101dee8af7233c8907a0f6cf06ad2a20575ed6.tar.gz podman-be101dee8af7233c8907a0f6cf06ad2a20575ed6.tar.bz2 podman-be101dee8af7233c8907a0f6cf06ad2a20575ed6.zip | |
Test Runtime.pullGoalFromImageReference instead of pullGoalNamesFromImageReference
pullGoalNamesFromImageReference has been added only to allow testing without
a storage.Store, because I thought that a storage.Store can only be created
by root.
It turns out that non-root stores, at least good enough for reference
parsing and formatting, are possible (and have existed in c/image/storage
tests), so this creates such a store, and modifies the existing
test to test the created c/image/storage.storageReference values
instead of strings; that is more representative, and clearly shows
the impact of further normalization in storageReference (like
defaulting to :latest on NameOnly references).
Eventually we will want to get rid of pullGoalNames / pullRefName.
Only modifies tests, so does not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Closes: #1198
Approved by: mheon
Diffstat (limited to 'libpod/image/pull.go')
0 files changed, 0 insertions, 0 deletions