migrate Podman to containers/common/libimage

Migrate the Podman code base over to `common/libimage` which replaces
`libpod/image` and a lot of glue code entirely.

Note that I tried to leave bread crumbs for changed tests.

Miscellaneous changes:

 * Some errors yield different messages which required to alter some
   tests.

 * I fixed some pre-existing issues in the code.  Others were marked as
   `//TODO`s to prevent the PR from exploding.

 * The `NamesHistory` of an image is returned as is from the storage.
   Previously, we did some filtering which I think is undesirable.
   Instead we should return the data as stored in the storage.

 * Touched handlers use the ABI interfaces where possible.

 * Local image resolution: previously Podman would match "foo" on
   "myfoo".  This behaviour has been changed and Podman will now
   only match on repository boundaries such that "foo" would match
   "my/foo" but not "myfoo".  I consider the old behaviour to be a
   bug, at the very least an exotic corner case.

 * Futhermore, "foo:none" does *not* resolve to a local image "foo"
   without tag anymore.  It's a hill I am (almost) willing to die on.

 * `image prune` prints the IDs of pruned images.  Previously, in some
   cases, the names were printed instead.  The API clearly states ID,
   so we should stick to it.

 * Compat endpoint image removal with _force_ deletes the entire not
   only the specified tag.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

10 files changed, 0 insertions, 4 deletions

diff --git a/libpod/image/testdata/docker-name-only.tar.xz b/libpod/image/testdata/docker-name-only.tar.xz
deleted file mode 100644
index 0cad9f108..000000000
--- a/libpod/image/testdata/docker-name-only.tar.xz
+++ /dev/null
diff --git a/libpod/image/testdata/docker-registry-name.tar.xz b/libpod/image/testdata/docker-registry-name.tar.xz
deleted file mode 100644
index 181816c2e..000000000
--- a/libpod/image/testdata/docker-registry-name.tar.xz
+++ /dev/null
diff --git a/libpod/image/testdata/docker-two-images.tar.xz b/libpod/image/testdata/docker-two-images.tar.xz
deleted file mode 100644
index 148d8a86b..000000000
--- a/libpod/image/testdata/docker-two-images.tar.xz
+++ /dev/null
diff --git a/libpod/image/testdata/docker-two-names.tar.xz b/libpod/image/testdata/docker-two-names.tar.xz
deleted file mode 100644
index 07fbc479c..000000000
--- a/libpod/image/testdata/docker-two-names.tar.xz
+++ /dev/null
diff --git a/libpod/image/testdata/docker-unnamed.tar.xz b/libpod/image/testdata/docker-unnamed.tar.xz
deleted file mode 100644
index ba6ea1bae..000000000
--- a/libpod/image/testdata/docker-unnamed.tar.xz
+++ /dev/null
diff --git a/libpod/image/testdata/oci-name-only.tar.gz b/libpod/image/testdata/oci-name-only.tar.gz
deleted file mode 100644
index 57bc07564..000000000
--- a/libpod/image/testdata/oci-name-only.tar.gz
+++ /dev/null
diff --git a/libpod/image/testdata/oci-non-docker-name.tar.gz b/libpod/image/testdata/oci-non-docker-name.tar.gz
deleted file mode 100644
index 5ffc0eabd..000000000
--- a/libpod/image/testdata/oci-non-docker-name.tar.gz
+++ /dev/null
diff --git a/libpod/image/testdata/oci-registry-name.tar.gz b/libpod/image/testdata/oci-registry-name.tar.gz
deleted file mode 100644
index e6df87339..000000000
--- a/libpod/image/testdata/oci-registry-name.tar.gz
+++ /dev/null
diff --git a/libpod/image/testdata/oci-unnamed.tar.gz b/libpod/image/testdata/oci-unnamed.tar.gz
deleted file mode 100644
index de445fdf8..000000000
--- a/libpod/image/testdata/oci-unnamed.tar.gz
+++ /dev/null
diff --git a/libpod/image/testdata/registries.conf b/libpod/image/testdata/registries.conf
deleted file mode 100644
index 16622a1ac..000000000
--- a/libpod/image/testdata/registries.conf
+++ /dev/null
@@ -1,4 +0,0 @@
-short-name-mode="enforcing"
-
-[aliases]
-"busybox"="docker.io/library/busybox"