diff options
author | Matthew Heon <mheon@redhat.com> | 2020-09-23 16:30:51 -0400 |
---|---|---|
committer | Matthew Heon <mheon@redhat.com> | 2020-09-24 14:48:26 -0400 |
commit | 00cca405d2cd0c3cd70f45ebc23337b033cca74a (patch) | |
tree | d35e12f97760214bd59977accdb10820704af547 /libpod/image/utils.go | |
parent | 08cc91926db1cd17509f8578e2ff00a94747dbd4 (diff) | |
download | podman-00cca405d2cd0c3cd70f45ebc23337b033cca74a.tar.gz podman-00cca405d2cd0c3cd70f45ebc23337b033cca74a.tar.bz2 podman-00cca405d2cd0c3cd70f45ebc23337b033cca74a.zip |
HTTP Attach: Wait until both STDIN and STDOUT finish
In the old code, there was a chance that we could return when
only one of STDIN or STDOUT had finished - this could lead to us
dropping either input to the container, or output from it, in the
case that one stream terminated early.
To resolve this, use separate channels to return STDOUT and STDIN
errors, and track which ones have returned cleanly to ensure that
we need bith in order to return from the HTTP attach function and
pass control back to the HTTP handler (which would assume we
exited cleanly and close the client's attach connection).
Signed-off-by: Matthew Heon <mheon@redhat.com>
Diffstat (limited to 'libpod/image/utils.go')
0 files changed, 0 insertions, 0 deletions