diff options
author | Ed Santiago <santiago@redhat.com> | 2022-05-10 05:27:13 -0600 |
---|---|---|
committer | Ed Santiago <santiago@redhat.com> | 2022-05-10 05:44:55 -0600 |
commit | 82f2b3edbc3c1b4d2c93ed4d1e66e6a6242fd1bb (patch) | |
tree | 5ba8bf6a1beeb320dece60dd6d707866ef9080e5 /libpod/info_test.go | |
parent | 28588235d2051bf673d528c293261f926fad0d92 (diff) | |
download | podman-82f2b3edbc3c1b4d2c93ed4d1e66e6a6242fd1bb.tar.gz podman-82f2b3edbc3c1b4d2c93ed4d1e66e6a6242fd1bb.tar.bz2 podman-82f2b3edbc3c1b4d2c93ed4d1e66e6a6242fd1bb.zip |
bloat check: make more robust
The use of 'C^' (parent) in 'git rebase' is counterintuitive,
at least to me: when C is a merge of multiple commits, rebase
picks each of those commits. That probably makes good sense
to a git expert, which I'm not.
Solution: forget using '^', just calculate the baseline sizes
by doing a checkout of the PR's parent.
Also: compute PR parent using git-merge-base instead of
blindly trusting $DEST_BRANCH (which may be volatile as
other PRs are merged).
Also: run git-rebase directly, not via make rule. That
indirection is too confusing here.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'libpod/info_test.go')
0 files changed, 0 insertions, 0 deletions