diff options
| author | Paul Holzinger <pholzing@redhat.com> | 2021-09-27 14:21:50 +0200 |
|---|---|---|
| committer | Paul Holzinger <pholzing@redhat.com> | 2021-09-28 13:40:27 +0200 |
| commit | 1c8926285d1ecdfe201fe68896657573dcdc22b7 (patch) | |
| tree | eaedddbd8eae580bd5075fc7008355cf5d8ee930 /libpod/network/cni/run.go | |
| parent | d0950f3efe2559049abbf45700309345c12a142f (diff) | |
| download | podman-1c8926285d1ecdfe201fe68896657573dcdc22b7.tar.gz podman-1c8926285d1ecdfe201fe68896657573dcdc22b7.tar.bz2 podman-1c8926285d1ecdfe201fe68896657573dcdc22b7.zip | |
move network alias validation to container create
Podman 4.0 currently errors when you use network aliases for a network which
has dns disabled. Because the error happens on network setup this can
cause regression for old working containers. The network backend should not
validate this. Instead podman should check this at container create time
and also for network connect.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'libpod/network/cni/run.go')
| -rw-r--r-- | libpod/network/cni/run.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/libpod/network/cni/run.go b/libpod/network/cni/run.go index 0f91a407c..bd873f89b 100644 --- a/libpod/network/cni/run.go +++ b/libpod/network/cni/run.go @@ -186,9 +186,6 @@ outer: } return errors.Errorf("requested static ip %s not in any subnet on network %s", ip.String(), network.libpodNet.Name) } - if len(netOpts.Aliases) > 0 && !network.libpodNet.DNSEnabled { - return errors.New("cannot set aliases on a network without dns enabled") - } return nil } |