summaryrefslogtreecommitdiff
path: root/libpod/network
diff options
context:
space:
mode:
authorPaul Holzinger <pholzing@redhat.com>2021-10-26 16:11:46 +0200
committerPaul Holzinger <pholzing@redhat.com>2021-10-26 16:11:46 +0200
commitefd1c080bf17ed662eeeeaf66647afd27ad27894 (patch)
tree7be151638c93d2b1a1f3475adda54a91d4e92e07 /libpod/network
parent4d75df8be380cff4df082bd6fc2f05aa2c433723 (diff)
downloadpodman-efd1c080bf17ed662eeeeaf66647afd27ad27894.tar.gz
podman-efd1c080bf17ed662eeeeaf66647afd27ad27894.tar.bz2
podman-efd1c080bf17ed662eeeeaf66647afd27ad27894.zip
Document to not set K8S envars for CNI
Setting these environment variables can cause issues with custom CNI plugins, see #12083. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'libpod/network')
-rw-r--r--libpod/network/cni/run.go6
1 files changed, 2 insertions, 4 deletions
diff --git a/libpod/network/cni/run.go b/libpod/network/cni/run.go
index bd873f89b..99b2adce5 100644
--- a/libpod/network/cni/run.go
+++ b/libpod/network/cni/run.go
@@ -196,10 +196,8 @@ func getRuntimeConfig(netns, conName, conID, networkName string, ports []cniPort
IfName: opts.InterfaceName,
Args: [][2]string{
{"IgnoreUnknown", "1"},
- // FIXME: Should we set the K8S args?
- //{"K8S_POD_NAMESPACE", conName},
- //{"K8S_POD_INFRA_CONTAINER_ID", conID},
- // K8S_POD_NAME is used by dnsname to get the container name
+ // Do not set the K8S env vars, see https://github.com/containers/podman/issues/12083.
+ // Only K8S_POD_NAME is used by dnsname to get the container name.
{"K8S_POD_NAME", conName},
},
CapabilityArgs: map[string]interface{}{},