diff options
| author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2022-05-26 06:07:40 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-26 06:07:40 -0400 |
| commit | 271f58f14282742e437cc810b216a7de27011ffc (patch) | |
| tree | ed84f4f63f8cbc45404d035dc52e58adced09f53 /libpod/pod_api.go | |
| parent | acdfb4d14f15814a1178985cce7175eaa13acd6a (diff) | |
| parent | badf76e172b10548f3a77a65c04ed7aaa4a78ce9 (diff) | |
| download | podman-271f58f14282742e437cc810b216a7de27011ffc.tar.gz podman-271f58f14282742e437cc810b216a7de27011ffc.tar.bz2 podman-271f58f14282742e437cc810b216a7de27011ffc.zip | |
Merge pull request #14369 from mheon/fixmes_2
Remove more FIXMEs
Diffstat (limited to 'libpod/pod_api.go')
| -rw-r--r-- | libpod/pod_api.go | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/libpod/pod_api.go b/libpod/pod_api.go index eede896a9..1c1e15984 100644 --- a/libpod/pod_api.go +++ b/libpod/pod_api.go @@ -152,8 +152,8 @@ func (p *Pod) stopWithTimeout(ctx context.Context, cleanup bool, timeout int) (m return nil, err } - // TODO: There may be cases where it makes sense to order stops based on - // dependencies. Should we bother with this? + // Stopping pods is not ordered by dependency. We haven't seen any case + // where this would actually matter. ctrErrChan := make(map[string]<-chan error) @@ -162,8 +162,9 @@ func (p *Pod) stopWithTimeout(ctx context.Context, cleanup bool, timeout int) (m c := ctr logrus.Debugf("Adding parallel job to stop container %s", c.ID()) retChan := parallel.Enqueue(ctx, func() error { - // TODO: Might be better to batch stop and cleanup - // together? + // Can't batch these without forcing Stop() to hold the + // lock for the full duration of the timeout. + // We probably don't want to do that. if timeout > -1 { if err := c.StopWithTimeout(uint(timeout)); err != nil { return err |