summaryrefslogtreecommitdiff
path: root/libpod/pod_api.go
diff options
context:
space:
mode:
authorMatthew Heon <matthew.heon@pm.me>2022-05-25 14:08:08 -0400
committerMatthew Heon <matthew.heon@pm.me>2022-05-25 14:10:02 -0400
commitbadf76e172b10548f3a77a65c04ed7aaa4a78ce9 (patch)
treed9a27b0f0a3268ce930c2c94ea2ef15d3b2ce468 /libpod/pod_api.go
parent819e5bcb943c6f604fdc65be1c0387055e0a9f20 (diff)
downloadpodman-badf76e172b10548f3a77a65c04ed7aaa4a78ce9.tar.gz
podman-badf76e172b10548f3a77a65c04ed7aaa4a78ce9.tar.bz2
podman-badf76e172b10548f3a77a65c04ed7aaa4a78ce9.zip
Remove more FIXMEs
Mostly, just removing the comments. These either have been done, or are no longer a good idea. No code changes. [NO NEW TESTS NEEDED] as such. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'libpod/pod_api.go')
-rw-r--r--libpod/pod_api.go9
1 files changed, 5 insertions, 4 deletions
diff --git a/libpod/pod_api.go b/libpod/pod_api.go
index eede896a9..1c1e15984 100644
--- a/libpod/pod_api.go
+++ b/libpod/pod_api.go
@@ -152,8 +152,8 @@ func (p *Pod) stopWithTimeout(ctx context.Context, cleanup bool, timeout int) (m
return nil, err
}
- // TODO: There may be cases where it makes sense to order stops based on
- // dependencies. Should we bother with this?
+ // Stopping pods is not ordered by dependency. We haven't seen any case
+ // where this would actually matter.
ctrErrChan := make(map[string]<-chan error)
@@ -162,8 +162,9 @@ func (p *Pod) stopWithTimeout(ctx context.Context, cleanup bool, timeout int) (m
c := ctr
logrus.Debugf("Adding parallel job to stop container %s", c.ID())
retChan := parallel.Enqueue(ctx, func() error {
- // TODO: Might be better to batch stop and cleanup
- // together?
+ // Can't batch these without forcing Stop() to hold the
+ // lock for the full duration of the timeout.
+ // We probably don't want to do that.
if timeout > -1 {
if err := c.StopWithTimeout(uint(timeout)); err != nil {
return err