diff options
| author | Matthew Heon <matthew.heon@pm.me> | 2020-01-29 14:04:51 -0500 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2020-01-29 14:04:51 -0500 |
| commit | 5d93c731afd5b21d88c025069da0e82455f09445 (patch) | |
| tree | 13a1b91a692e8164b70fbdfeec16e7191b45f8d6 /libpod/runtime_pod_linux.go | |
| parent | 955866c97da3007be20a6812eb8afa48e9833d23 (diff) | |
| download | podman-5d93c731afd5b21d88c025069da0e82455f09445.tar.gz podman-5d93c731afd5b21d88c025069da0e82455f09445.tar.bz2 podman-5d93c731afd5b21d88c025069da0e82455f09445.zip | |
Deprecate & remove IsCtrSpecific in favor of IsAnon
In Podman 1.6.3, we added support for anonymous volumes - fixing
our old, broken support for named volumes that were created with
containers. Unfortunately, this reused the database field we used
for the old implementation, and toggled volume removal on for
`podman run --rm` - so now, we were removing *named* volumes
created with older versions of Podman.
We can't modify these old volumes in the DB, so the next-safest
thing to do is swap to a new field to indicate volumes should be
removed. Problem: Volumes created with 1.6.3 and up until this
lands, even anonymous volumes, will not be removed. However, this
is safer than removing too many volumes, as we were doing before.
Fixes #5009
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'libpod/runtime_pod_linux.go')
| -rw-r--r-- | libpod/runtime_pod_linux.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libpod/runtime_pod_linux.go b/libpod/runtime_pod_linux.go index 450c64d24..5b0111b85 100644 --- a/libpod/runtime_pod_linux.go +++ b/libpod/runtime_pod_linux.go @@ -261,7 +261,7 @@ func (r *Runtime) removePod(ctx context.Context, p *Pod, removeCtrs, force bool) logrus.Errorf("Error retrieving volume %s: %v", volName, err) continue } - if !volume.IsCtrSpecific() { + if !volume.Anonymous() { continue } if err := r.removeVolume(ctx, volume, false); err != nil { |