diff options
author | Peter Hunt <pehunt@redhat.com> | 2019-03-07 12:52:54 -0500 |
---|---|---|
committer | Peter Hunt <pehunt@redhat.com> | 2019-03-28 09:54:31 -0400 |
commit | 0d0ad59641a308450d694d4c2fb95303c64fabf8 (patch) | |
tree | cce1ff87f1c9c501b70ee360fceacb512808e5bd /libpod/util_linux.go | |
parent | 850326cc192444d1c5cfd8ba6e1015f653b41e73 (diff) | |
download | podman-0d0ad59641a308450d694d4c2fb95303c64fabf8.tar.gz podman-0d0ad59641a308450d694d4c2fb95303c64fabf8.tar.bz2 podman-0d0ad59641a308450d694d4c2fb95303c64fabf8.zip |
Default to SELinux private label for play kube mounts
Before, there were SELinux denials when a volume was bind-mounted by podman play kube.
Partially fix this by setting the default private label for mounts created by play kube (with DirectoryOrCreate)
For volumes mounted as Directory, the user will have to set their own SELinux permissions on the mount point
also remove left over debugging print statement
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Diffstat (limited to 'libpod/util_linux.go')
-rw-r--r-- | libpod/util_linux.go | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/libpod/util_linux.go b/libpod/util_linux.go index 30e2538c3..a801df2ee 100644 --- a/libpod/util_linux.go +++ b/libpod/util_linux.go @@ -9,6 +9,7 @@ import ( "github.com/containerd/cgroups" "github.com/containers/libpod/pkg/util" spec "github.com/opencontainers/runtime-spec/specs-go" + "github.com/opencontainers/selinux/go-selinux/label" "github.com/pkg/errors" "github.com/sirupsen/logrus" ) @@ -91,3 +92,23 @@ func GetV1CGroups(excludes []string) cgroups.Hierarchy { return filtered, nil } } + +// LabelVolumePath takes a mount path for a volume and gives it an +// selinux label of either shared or not +func LabelVolumePath(path string, shared bool) error { + _, mountLabel, err := label.InitLabels([]string{}) + if err != nil { + return errors.Wrapf(err, "error getting default mountlabels") + } + if err := label.ReleaseLabel(mountLabel); err != nil { + return errors.Wrapf(err, "error releasing label %q", mountLabel) + } + if err := label.Relabel(path, mountLabel, shared); err != nil { + permString := "private" + if shared { + permString = "shared" + } + return errors.Wrapf(err, "error setting selinux label for %s to %q as %s", path, mountLabel, permString) + } + return nil +} |