summaryrefslogtreecommitdiff
path: root/libpod/volume_internal.go
diff options
context:
space:
mode:
authorPeter <peter@psanders.me>2020-09-13 10:47:42 -0400
committerPeter <peter@psanders.me>2020-09-13 23:24:15 -0400
commitc8f9117cef3cb72a506881b634e097368da1e854 (patch)
tree0ad14aad75bb54067e1213ca7f0158488add6672 /libpod/volume_internal.go
parent25fb0c2b966c193e8c4045e440316850f6f1b889 (diff)
downloadpodman-c8f9117cef3cb72a506881b634e097368da1e854.tar.gz
podman-c8f9117cef3cb72a506881b634e097368da1e854.tar.bz2
podman-c8f9117cef3cb72a506881b634e097368da1e854.zip
Fix mismatch between log messages and behavior of libpod.LabelVolumePath.
A reading of LabelVolumePath suggests that the intended behavior upon encountering ENOTSUP is to log the issue and continue without error, while all other errors in the Relabeling operation should be considered errors of LabelVolumePath and passed up accordingly. This is not the behavior that is encountered, as this test shows: it is instead considered an error if and only if the Relabeling operation returns ENOTSUP, spitting out a somewhat incongruous error message, while all other error types that may be returned are logged without being propogated, with an even more incongruous error message saying that the operation was not supported. The comparison was changed to match the behavior documented by the log messages, and a test was added that will simulate executing this function on a path where the mounted filesystem does not support SELinux labels, with the assertion that the function should not return an error in order to highlight the condition these changes seek to alleviate. Signed-off-by: Peter <peter@psanders.me>
Diffstat (limited to 'libpod/volume_internal.go')
0 files changed, 0 insertions, 0 deletions