diff options
| author | Matthew Heon <matthew.heon@pm.me> | 2019-08-23 13:24:06 -0400 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2019-08-28 14:28:18 -0400 |
| commit | 5bdd97f77fc3100c6338928d4d54af32273d36fb (patch) | |
| tree | 1b64432a31b0093d2b6fa6331097e6ccd53ccd7d /libpod | |
| parent | d45595d9cc2ae60a5e23d081e27a8ba0ab952113 (diff) | |
| download | podman-5bdd97f77fc3100c6338928d4d54af32273d36fb.tar.gz podman-5bdd97f77fc3100c6338928d4d54af32273d36fb.tar.bz2 podman-5bdd97f77fc3100c6338928d4d54af32273d36fb.zip | |
Set base mount options for bind mounts from base system
If I mount, say, /usr/bin into my container - I expect to be able
to run the executables in that mount. Unconditionally applying
noexec would be a bad idea.
Before my patches to change mount options and allow exec/dev/suid
being set explicitly, we inferred the mount options from where on
the base system the mount originated, and the options it had
there. Implement the same functionality for the new option
handling.
There's a lot of performance left on the table here, but I don't
know that this is ever going to take enough time to make it worth
optimizing.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'libpod')
| -rw-r--r-- | libpod/options.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libpod/options.go b/libpod/options.go index f4bf536b3..6df1ca5be 100644 --- a/libpod/options.go +++ b/libpod/options.go @@ -1360,7 +1360,7 @@ func WithNamedVolumes(volumes []*ContainerNamedVolume) CtrCreateOption { } destinations[vol.Dest] = true - mountOpts, err := util.ProcessOptions(vol.Options, false) + mountOpts, err := util.ProcessOptions(vol.Options, false, nil) if err != nil { return errors.Wrapf(err, "error processing options for named volume %q mounted at %q", vol.Name, vol.Dest) } |