summaryrefslogtreecommitdiff
path: root/libpod
diff options
context:
space:
mode:
authorUrvashi Mohnani <umohnani@redhat.com>2021-10-12 16:02:47 -0400
committerUrvashi Mohnani <umohnani@redhat.com>2021-10-13 15:18:04 -0400
commit5d18fb92397720eb416f760a55fe37ad2d5ae63a (patch)
tree7dd5b94ee86aaa1119780e790e9c309174b5966c /libpod
parent9f1452cbb51bbca221c307e6da60af51a65489cd (diff)
downloadpodman-5d18fb92397720eb416f760a55fe37ad2d5ae63a.tar.gz
podman-5d18fb92397720eb416f760a55fe37ad2d5ae63a.tar.bz2
podman-5d18fb92397720eb416f760a55fe37ad2d5ae63a.zip
Don't add image entrypoint to the generate kube yaml
If no entrypoint or command is set in the podman create command, and the image command or entrypoint is being used as the default, then do not add the image command or entrypoint to the generated kube yaml. Kubernetes knows to default to the image command and/or entrypoint settings when not defined in the kube yaml. Add and modify tests for this case. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
Diffstat (limited to 'libpod')
-rw-r--r--libpod/kube.go4
1 files changed, 3 insertions, 1 deletions
diff --git a/libpod/kube.go b/libpod/kube.go
index 43acd856d..d68140d5e 100644
--- a/libpod/kube.go
+++ b/libpod/kube.go
@@ -481,7 +481,9 @@ func containerToV1Container(ctx context.Context, c *Container) (v1.Container, []
if err != nil {
return kubeContainer, kubeVolumes, nil, annotations, err
}
- if reflect.DeepEqual(imgData.Config.Cmd, kubeContainer.Command) {
+ // If the user doesn't set a command/entrypoint when creating the container with podman and
+ // is using the image command or entrypoint from the image, don't add it to the generated kube yaml
+ if reflect.DeepEqual(imgData.Config.Cmd, kubeContainer.Command) || reflect.DeepEqual(imgData.Config.Entrypoint, kubeContainer.Command) {
kubeContainer.Command = nil
}