diff options
| author | Korhonen Sami (Samlink) <k847259@ubuntu.saminet.fi> | 2020-07-09 15:11:44 +0300 |
|---|---|---|
| committer | Korhonen Sami (Samlink) <k847259@ubuntu.saminet.fi> | 2020-07-09 22:16:07 +0300 |
| commit | cf64e3cad89053e85071760eb911b58739867163 (patch) | |
| tree | 0b56492c62fff6b4280ef0bb7dda2c325fa928d4 /pkg/api/handlers/compat/containers_attach.go | |
| parent | d9cd0032f7478e625329326d7593162a9f1e8c1e (diff) | |
| download | podman-cf64e3cad89053e85071760eb911b58739867163.tar.gz podman-cf64e3cad89053e85071760eb911b58739867163.tar.bz2 podman-cf64e3cad89053e85071760eb911b58739867163.zip | |
Remove hijacked connections from active connections list
StateHijacked is a terminal state. If hijacked connection
is registered as an active connection, connection will
never be unregistered. This causes two issues
First issue is that active connection counters are off.
Second issue is a resource leak caused by connection
object that is stored to a map.
After this patch hijacked connections are no longer
visible in counters. If a counter for hijacked
connections is required, podman must track
connections returned by Hijacker.Hijack()
It might make sense to develop abstraction layer for
hijacking - and move all hijacking related code to a
separate package. Hijacking code is prone to resource
leaks and it should be thoroughly tested.
Signed-off-by: Sami Korhonen <skorhone@gmail.com>
Diffstat (limited to 'pkg/api/handlers/compat/containers_attach.go')
0 files changed, 0 insertions, 0 deletions