diff options
author | Brent Baude <bbaude@redhat.com> | 2020-01-30 12:40:19 -0600 |
---|---|---|
committer | Brent Baude <bbaude@redhat.com> | 2020-01-31 08:38:25 -0600 |
commit | f1eaccedfa08455d699d00dcda63b95aeb34833e (patch) | |
tree | 65d385fd683a66686b225827c760e5bc95f7e346 /pkg/api/handlers/libpod/images.go | |
parent | 36af2833f954e1c822b917ecff45c05858188c2d (diff) | |
download | podman-f1eaccedfa08455d699d00dcda63b95aeb34833e.tar.gz podman-f1eaccedfa08455d699d00dcda63b95aeb34833e.tar.bz2 podman-f1eaccedfa08455d699d00dcda63b95aeb34833e.zip |
fix longname handling for bindings
the api needs to account for image input where the image is encoded as a fqd image name.
Signed-off-by: Brent Baude <bbaude@redhat.com>
Diffstat (limited to 'pkg/api/handlers/libpod/images.go')
-rw-r--r-- | pkg/api/handlers/libpod/images.go | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/pkg/api/handlers/libpod/images.go b/pkg/api/handlers/libpod/images.go index 9f0876618..202ed5eaa 100644 --- a/pkg/api/handlers/libpod/images.go +++ b/pkg/api/handlers/libpod/images.go @@ -11,7 +11,6 @@ import ( "github.com/containers/libpod/libpod" "github.com/containers/libpod/pkg/api/handlers" "github.com/containers/libpod/pkg/api/handlers/utils" - "github.com/gorilla/mux" "github.com/gorilla/schema" "github.com/pkg/errors" ) @@ -28,11 +27,8 @@ import ( // create func ImageExists(w http.ResponseWriter, r *http.Request) { - // 200 ok - // 404 no such - // 500 internal runtime := r.Context().Value("runtime").(*libpod.Runtime) - name := mux.Vars(r)["name"] + name := utils.GetName(r) _, err := runtime.ImageRuntime().NewFromLocal(name) if err != nil { @@ -45,7 +41,7 @@ func ImageExists(w http.ResponseWriter, r *http.Request) { func ImageTree(w http.ResponseWriter, r *http.Request) { // tree is a bit of a mess ... logic is in adapter and therefore not callable from here. needs rework - // name := mux.Vars(r)["name"] + // name := utils.GetName(r) // _, layerInfoMap, _, err := s.Runtime.Tree(name) // if err != nil { // Error(w, "Something went wrong.", http.StatusInternalServerError, errors.Wrapf(err, "Failed to find image information for %q", name)) @@ -57,7 +53,7 @@ func ImageTree(w http.ResponseWriter, r *http.Request) { } func GetImage(w http.ResponseWriter, r *http.Request) { - name := mux.Vars(r)["name"] + name := utils.GetName(r) newImage, err := handlers.GetImage(r, name) if err != nil { utils.Error(w, "Something went wrong.", http.StatusNotFound, errors.Wrapf(err, "Failed to find image %s", name)) @@ -160,7 +156,7 @@ func ExportImage(w http.ResponseWriter, r *http.Request) { utils.Error(w, "Something went wrong.", http.StatusInternalServerError, errors.Wrap(err, "unable to close tempfile")) return } - name := mux.Vars(r)["name"] + name := utils.GetName(r) newImage, err := runtime.ImageRuntime().NewFromLocal(name) if err != nil { utils.ImageNotFound(w, name, err) |