Merge pull request #4965 from baude/reviewcorrections3

APIv2 review corrections #3

1 files changed, 9 insertions, 3 deletions

diff --git a/pkg/api/handlers/utils/images.go b/pkg/api/handlers/utils/images.go
index a0d340471..2b651584a 100644
--- a/pkg/api/handlers/utils/images.go
+++ b/pkg/api/handlers/utils/images.go
@@ -6,6 +6,7 @@ import (
 
 	"github.com/containers/libpod/libpod"
 	"github.com/containers/libpod/libpod/image"
+	"github.com/gorilla/mux"
 	"github.com/gorilla/schema"
 )
 
@@ -15,17 +16,22 @@ func GetImages(w http.ResponseWriter, r *http.Request) ([]*image.Image, error) {
 	decoder := r.Context().Value("decoder").(*schema.Decoder)
 	runtime := r.Context().Value("runtime").(*libpod.Runtime)
 	query := struct {
-		// all     bool # all is currently unused
+		All     bool
 		Filters map[string][]string `schema:"filters"`
-		// digests bool # digests is currently unused
+		Digests bool
 	}{
 		// This is where you can override the golang default value for one of fields
 	}
+	// TODO I think all is implemented with a filter?
+
 	if err := decoder.Decode(&query, r.URL.Query()); err != nil {
 		return nil, err
 	}
-
 	var filters = []string{}
+	if _, found := mux.Vars(r)["digests"]; found && query.Digests {
+		UnSupportedParameter("digests")
+	}
+
 	if _, found := r.URL.Query()["filters"]; found {
 		filters = append(filters, fmt.Sprintf("reference=%s", ""))
 	}