Merge pull request #6878 from skorhone/fix/docker_v1_24_image_list_compatibility

Add support for Filter query parameter to list images api

1 files changed, 11 insertions, 2 deletions

diff --git a/pkg/api/handlers/utils/images.go b/pkg/api/handlers/utils/images.go
index 195e71b75..bf981b547 100644
--- a/pkg/api/handlers/utils/images.go
+++ b/pkg/api/handlers/utils/images.go
@@ -60,6 +60,7 @@ func GetImages(w http.ResponseWriter, r *http.Request) ([]*image.Image, error) {
 		All     bool
 		Filters map[string][]string `schema:"filters"`
 		Digests bool
+		Filter  string // Docker 1.24 compatibility
 	}{
 		// This is where you can override the golang default value for one of fields
 	}
@@ -76,8 +77,16 @@ func GetImages(w http.ResponseWriter, r *http.Request) ([]*image.Image, error) {
 		err    error
 	)
 
-	if len(query.Filters) > 0 {
-		for k, v := range query.Filters {
+	queryFilters := query.Filters
+	if !IsLibpodRequest(r) && len(query.Filter) > 0 { // Docker 1.24 compatibility
+		if queryFilters == nil {
+			queryFilters = make(map[string][]string)
+		}
+		queryFilters["reference"] = append(queryFilters["reference"], query.Filter)
+	}
+
+	if len(queryFilters) > 0 {
+		for k, v := range queryFilters {
 			filters = append(filters, fmt.Sprintf("%s=%s", k, strings.Join(v, "=")))
 		}
 		images, err = runtime.ImageRuntime().GetImagesWithFilters(filters)