diff options
author | Brent Baude <bbaude@redhat.com> | 2020-01-24 08:59:20 -0600 |
---|---|---|
committer | Brent Baude <bbaude@redhat.com> | 2020-01-25 15:09:09 -0600 |
commit | 5da70b04dd95263a536cc148288d2e20cd9dea30 (patch) | |
tree | 3d28c000a7941d9f8ea4aef906d29a44c2e80484 /pkg/api/handlers/utils | |
parent | 81e59a742b46d41848c8c213e155fbc9ecc4e5f8 (diff) | |
download | podman-5da70b04dd95263a536cc148288d2e20cd9dea30.tar.gz podman-5da70b04dd95263a536cc148288d2e20cd9dea30.tar.bz2 podman-5da70b04dd95263a536cc148288d2e20cd9dea30.zip |
APIv2 review corrections #3
The third pass of corrections for the APIv2.
Signed-off-by: Brent Baude <bbaude@redhat.com>
Diffstat (limited to 'pkg/api/handlers/utils')
-rw-r--r-- | pkg/api/handlers/utils/images.go | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/pkg/api/handlers/utils/images.go b/pkg/api/handlers/utils/images.go index a0d340471..2b651584a 100644 --- a/pkg/api/handlers/utils/images.go +++ b/pkg/api/handlers/utils/images.go @@ -6,6 +6,7 @@ import ( "github.com/containers/libpod/libpod" "github.com/containers/libpod/libpod/image" + "github.com/gorilla/mux" "github.com/gorilla/schema" ) @@ -15,17 +16,22 @@ func GetImages(w http.ResponseWriter, r *http.Request) ([]*image.Image, error) { decoder := r.Context().Value("decoder").(*schema.Decoder) runtime := r.Context().Value("runtime").(*libpod.Runtime) query := struct { - // all bool # all is currently unused + All bool Filters map[string][]string `schema:"filters"` - // digests bool # digests is currently unused + Digests bool }{ // This is where you can override the golang default value for one of fields } + // TODO I think all is implemented with a filter? + if err := decoder.Decode(&query, r.URL.Query()); err != nil { return nil, err } - var filters = []string{} + if _, found := mux.Vars(r)["digests"]; found && query.Digests { + UnSupportedParameter("digests") + } + if _, found := r.URL.Query()["filters"]; found { filters = append(filters, fmt.Sprintf("reference=%s", "")) } |