summaryrefslogtreecommitdiff
path: root/pkg/api/handlers
diff options
context:
space:
mode:
authorAditya R <arajan@redhat.com>2022-02-07 13:38:16 +0530
committerAditya R <arajan@redhat.com>2022-02-07 13:38:19 +0530
commit3b561a468232c18c63d98920ce2812721d853f29 (patch)
tree88d0ced5d610484b088c07cb4da23bd6b3569502 /pkg/api/handlers
parentab4af502b3f60f891192356eddaa13092f785612 (diff)
downloadpodman-3b561a468232c18c63d98920ce2812721d853f29.tar.gz
podman-3b561a468232c18c63d98920ce2812721d853f29.tar.bz2
podman-3b561a468232c18c63d98920ce2812721d853f29.zip
compat: endpoint /build must set header content type as application/json in reponse
Lot of clients are expecting proper `Content-type: application/json` configured in response headers of `/build` compat api. Following commit fixes that. Fixes issues where code is setting header field after writing header which is wrong. We must set `content-type` before we write and flush http header. Signed-off-by: Aditya R <arajan@redhat.com>
Diffstat (limited to 'pkg/api/handlers')
-rw-r--r--pkg/api/handlers/compat/images_build.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/api/handlers/compat/images_build.go b/pkg/api/handlers/compat/images_build.go
index cc9667202..0ebf74f98 100644
--- a/pkg/api/handlers/compat/images_build.go
+++ b/pkg/api/handlers/compat/images_build.go
@@ -605,8 +605,8 @@ func BuildImage(w http.ResponseWriter, r *http.Request) {
}
// Send headers and prime client for stream to come
- w.WriteHeader(http.StatusOK)
w.Header().Set("Content-Type", "application/json")
+ w.WriteHeader(http.StatusOK)
flush()
body := w.(io.Writer)